diff options
| author | Oliver O'Halloran <oohall@gmail.com> | 2016-12-21 15:52:23 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-01-04 17:15:34 +1100 |
| commit | 458b3f8e38e4e61c880ba640d4a30550b2693813 (patch) | |
| tree | a28eb170728b50a9e9ed4306e82804fc13ed8304 /hw/fsp/fsp-console.c | |
| parent | f38ed2656a5f9983948b79ccf5e1d344035bf531 (diff) | |
| download | skiboot-458b3f8e38e4e61c880ba640d4a30550b2693813.zip skiboot-458b3f8e38e4e61c880ba640d4a30550b2693813.tar.gz skiboot-458b3f8e38e4e61c880ba640d4a30550b2693813.tar.bz2 | |
console: don't use __flush_console() outside console.c
There is only one use of this function outside of console.c and that
usage is broken. As the name suggests this is an internal function that
is only safe when the console lock held is held. flush_console() will
acquire the lock for the caller so that should be used instead.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp/fsp-console.c')
| -rw-r--r-- | hw/fsp/fsp-console.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c index 0080d73..46ac28b 100644 --- a/hw/fsp/fsp-console.c +++ b/hw/fsp/fsp-console.c @@ -751,7 +751,7 @@ void fsp_console_poll(void *data __unused) continue; } if (fs->log_port) { - __flush_console(true); + flush_console(); opal_update_pending_evt(fs->irq, 0); } else { #ifdef OPAL_DEBUG_CONSOLE_POLL |