aboutsummaryrefslogtreecommitdiff
path: root/hw/cec.c
diff options
context:
space:
mode:
authorDaniel Axtens <dja@axtens.net>2015-11-16 15:57:36 +1100
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-11-18 11:30:44 +1100
commit0baf63f38757d356de3436ac0ab47511f98b8723 (patch)
tree46b0fa3cbfd410aab235cc36898de98427b45f63 /hw/cec.c
parent30b0074073fb419a0586c6da39852aa412869ed4 (diff)
downloadskiboot-0baf63f38757d356de3436ac0ab47511f98b8723.zip
skiboot-0baf63f38757d356de3436ac0ab47511f98b8723.tar.gz
skiboot-0baf63f38757d356de3436ac0ab47511f98b8723.tar.bz2
Drop support for p5ioc2
p5ioc2 is used by approximately 2 machines in the world, and has never ever been a supported configuration. Not only is the code virtually unused and very tricky to test, but keeping it around is making life unnecessarily difficult: - It's more complexity to manage for things such as PCI slot support - It's more code for static analysis to cover, which means more time fixing bugs that affect no-one. - It's bloating every single install of skiboot for no benefit. - It's reducing coverage stats, which is sad. Drop p5ioc2. Signed-off-by: Daniel Axtens <dja@axtens.net> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/cec.c')
-rw-r--r--hw/cec.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/hw/cec.c b/hw/cec.c
index 23d6362..1743f4d 100644
--- a/hw/cec.c
+++ b/hw/cec.c
@@ -17,7 +17,6 @@
#include <skiboot.h>
#include <cec.h>
#include <p7ioc.h>
-#include <p5ioc2.h>
#include <interrupts.h>
#include <opal-api.h>
@@ -53,19 +52,17 @@ void cec_reset(void)
}
}
+/* This was only supported by p5ioc, which was dropped */
static int64_t opal_pci_set_hub_tce_memory(uint64_t hub_id,
- uint64_t tce_mem_addr,
- uint64_t tce_mem_size)
+ uint64_t tce_mem_addr __unused,
+ uint64_t tce_mem_size __unused)
{
struct io_hub *hub = cec_get_hub_by_id(hub_id);
if (!hub)
return OPAL_PARAMETER;
- if (!hub->ops->set_tce_mem)
- return OPAL_UNSUPPORTED;
-
- return hub->ops->set_tce_mem(hub, tce_mem_addr, tce_mem_size);
+ return OPAL_UNSUPPORTED;
}
opal_call(OPAL_PCI_SET_HUB_TCE_MEMORY, opal_pci_set_hub_tce_memory, 3);