Fix potential negative loop bound in hdata/pcia.c

HDIF_get_iarray_size could return -1 on failure, so detect that
and somewhat gracefully back out of an awful loop

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/hdata/pcia.c b/hdata/pcia.c
index efcfa7c..4495fbe 100644
--- a/hdata/pcia.c
+++ b/hdata/pcia.c
@@ -35,9 +35,11 @@ static unsigned int pcia_index(const void *pcia)
 static const struct sppcia_cpu_thread *find_tada(const void *pcia,
 						 unsigned int thread)
 {
-	unsigned int count = HDIF_get_iarray_size(pcia,
-						  SPPCIA_IDATA_THREAD_ARRAY);
-	unsigned int i;
+	int count = HDIF_get_iarray_size(pcia, SPPCIA_IDATA_THREAD_ARRAY);
+	int i;
+
+	if (count < 0)
+		return NULL;
 
 	for (i = 0; i < count; i++) {
 		const struct sppcia_cpu_thread *t;