diff options
| author | Gavin Shan <gwshan@linux.vnet.ibm.com> | 2016-10-21 16:47:53 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-10-24 12:18:43 +1100 |
| commit | 1408f6f9baa684f280dfb2c4a66daa4d5db996b2 (patch) | |
| tree | 8ac3a09cac475bf84a7e20d7cf3ae5fafa626dc1 /doc | |
| parent | 0074e3d9446e7174a2bff8562241f5cb9eee547e (diff) | |
| download | skiboot-1408f6f9baa684f280dfb2c4a66daa4d5db996b2.zip skiboot-1408f6f9baa684f280dfb2c4a66daa4d5db996b2.tar.gz skiboot-1408f6f9baa684f280dfb2c4a66daa4d5db996b2.tar.bz2 | |
pci: Check power state before powering off slot
I made the inappropriate assumption: PCI slot's power state is
always on from the beginning. We don't check the slot's power
state before turning it off in PCI enumeration path when there
are no PCI adapters behind the slot. The PCI slot's power might
have been turned off and we needn't power it off again. Otherwise,
the below (not harmful) message is raised:
[ 47.243635711,5] SkiBoot skiboot-5.4.0-rc1 starting...
:
[ 13.239871630,5] PHB#0001:02:01.0 Error -1 powering off slot
This checks power state and avoid turning it off again if it's
already in off state. Flag PCI_SLOT_FLAG_BOOTUP is also removed
after the requested operation is completed as the flag should
be used at skiboot booting stage.
Cc: stable # 5.3.0+
Reported-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Tested-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions