aboutsummaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorRussell Currey <ruscur@russell.cc>2016-08-18 16:42:53 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2016-08-30 17:02:03 +1000
commit863ac3c5d2f8a5ea5d471167f3da5cb07aab72fc (patch)
tree17f09f160713ecc6bc14928d9ef8cc1c53e65c66 /doc
parent2b426c488eae5b5ba175ba6a8434d288582347fa (diff)
downloadskiboot-863ac3c5d2f8a5ea5d471167f3da5cb07aab72fc.zip
skiboot-863ac3c5d2f8a5ea5d471167f3da5cb07aab72fc.tar.gz
skiboot-863ac3c5d2f8a5ea5d471167f3da5cb07aab72fc.tar.bz2
pci: Standardise on uint64_t pe_number
Throughout skiboot (and the kernel) PE numbers are named "pe_no", "pe_num" and "pe_number", and sized as 16, 32 and 64bit uints depending on where you look. This is annoying and potentially misleading in cases such as the OPAL API, where different calls have different int sizes even though the PE number they want is the same. Fix this by making *everything* uint64_t pe_number. In doing this, there are some whitespace fixes and mve_number gets dragged into this as well for cases like set_msi_{32/64} where they essentially mean the same thing. Signed-off-by: Russell Currey <ruscur@russell.cc> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'doc')
-rw-r--r--doc/opal-api/opal-pci-map-pe-dma-window-44.rst14
-rw-r--r--doc/opal-api/opal-pci-map-pe-mmio-window-29.rst10
-rw-r--r--doc/opal-api/opal-pci-set-mve-33.rst2
-rw-r--r--doc/opal-api/opal-pci-set-xive-pe-37.rst2
-rw-r--r--doc/opal-api/opal-pci-tce-kill-126.rst2
5 files changed, 15 insertions, 15 deletions
diff --git a/doc/opal-api/opal-pci-map-pe-dma-window-44.rst b/doc/opal-api/opal-pci-map-pe-dma-window-44.rst
index dbfe231..bec8f08 100644
--- a/doc/opal-api/opal-pci-map-pe-dma-window-44.rst
+++ b/doc/opal-api/opal-pci-map-pe-dma-window-44.rst
@@ -4,12 +4,13 @@ OPAL_PCI_MAP_PE_DMA_WINDOW
#define OPAL_PCI_MAP_PE_DMA_WINDOW 44
- static int64_t opal_pci_map_pe_dma_window(uint64_t phb_id, uint16_t pe_number,
- uint16_t window_id,
- uint16_t tce_levels,
- uint64_t tce_table_addr,
- uint64_t tce_table_size,
- uint64_t tce_page_size)
+ static int64_t opal_pci_map_pe_dma_window(uint64_t phb_id,
+ uint64_t pe_number,
+ uint16_t window_id,
+ uint16_t tce_levels,
+ uint64_t tce_table_addr,
+ uint64_t tce_table_size,
+ uint64_t tce_page_size)
**WARNING:** following documentation is from old sources, and is possibly
not representative of OPALv3 as implemented by skiboot. This should be
@@ -99,4 +100,3 @@ Return value: ::
return OPAL_PARAMETER;
if (!phb->ops->map_pe_dma_window)
return OPAL_UNSUPPORTED;
-
diff --git a/doc/opal-api/opal-pci-map-pe-mmio-window-29.rst b/doc/opal-api/opal-pci-map-pe-mmio-window-29.rst
index 595c588..aaa1d9e 100644
--- a/doc/opal-api/opal-pci-map-pe-mmio-window-29.rst
+++ b/doc/opal-api/opal-pci-map-pe-mmio-window-29.rst
@@ -4,10 +4,11 @@ OPAL_PCI_MAP_PE_MMIO_WINDOW
#define OPAL_PCI_MAP_PE_MMIO_WINDOW 29
- static int64_t opal_pci_map_pe_mmio_window(uint64_t phb_id, uint16_t pe_number,
- uint16_t window_type,
- uint16_t window_num,
- uint16_t segment_num)
+ static int64_t opal_pci_map_pe_mmio_window(uint64_t phb_id,
+ uint64_t pe_number,
+ uint16_t window_type,
+ uint16_t window_num,
+ uint16_t segment_num)
**WARNING:** following documentation is from old sources, and is possibly
not representative of OPALv3 as implemented by skiboot. This should be
@@ -43,4 +44,3 @@ Return value: ::
return OPAL_PARAMETER;
if (!phb->ops->map_pe_mmio_window)
return OPAL_UNSUPPORTED;
-
diff --git a/doc/opal-api/opal-pci-set-mve-33.rst b/doc/opal-api/opal-pci-set-mve-33.rst
index 66a81ed..bf53587 100644
--- a/doc/opal-api/opal-pci-set-mve-33.rst
+++ b/doc/opal-api/opal-pci-set-mve-33.rst
@@ -5,7 +5,7 @@ OPAL_PCI_SET_MVE
#define OPAL_PCI_SET_MVE 33
static int64_t opal_pci_set_mve(uint64_t phb_id, uint32_t mve_number,
- uint32_t pe_number)
+ uint64_t pe_number)
**WARNING:** following documentation is from old sources, and is possibly
not representative of OPALv3 as implemented by skiboot. This should be
diff --git a/doc/opal-api/opal-pci-set-xive-pe-37.rst b/doc/opal-api/opal-pci-set-xive-pe-37.rst
index 67a86e7..a5c6582 100644
--- a/doc/opal-api/opal-pci-set-xive-pe-37.rst
+++ b/doc/opal-api/opal-pci-set-xive-pe-37.rst
@@ -2,7 +2,7 @@ OPAL_PCI_SET_XIVE_PE
====================
::
- static int64_t opal_pci_set_xive_pe(uint64_t phb_id, uint32_t pe_number,
+ static int64_t opal_pci_set_xive_pe(uint64_t phb_id, uint64_t pe_number,
uint32_t xive_num)
**WARNING:** following documentation is from old sources, and is possibly
diff --git a/doc/opal-api/opal-pci-tce-kill-126.rst b/doc/opal-api/opal-pci-tce-kill-126.rst
index 4aa6eb9..dc7ab6b 100644
--- a/doc/opal-api/opal-pci-tce-kill-126.rst
+++ b/doc/opal-api/opal-pci-tce-kill-126.rst
@@ -4,7 +4,7 @@ OPAL_PCI_TCE_KILL
int64_t opal_pci_tce_kill(uint64_t phb_id,
uint32_t kill_type,
- uint32_t pe_num,
+ uint64_t pe_number,
uint32_t tce_size,
uint64_t dma_addr,
uint32_t npages)