diff options
author | Stewart Smith <stewart@linux.ibm.com> | 2019-05-31 16:13:10 +1000 |
---|---|---|
committer | Stewart Smith <stewart@linux.ibm.com> | 2019-06-03 10:20:00 +1000 |
commit | 5eec3e33bc066245c191106cf5a3f031973d7850 (patch) | |
tree | 8cf26600dc959d1e316feea0d7d2e743cbfc3825 /doc/opal-api | |
parent | 484e81580580c8850f383144aad9845b9c4bc495 (diff) | |
download | skiboot-5eec3e33bc066245c191106cf5a3f031973d7850.zip skiboot-5eec3e33bc066245c191106cf5a3f031973d7850.tar.gz skiboot-5eec3e33bc066245c191106cf5a3f031973d7850.tar.bz2 |
Remove unused OPAL_PCI_EEH_FREEZE_STATUS2
This call was introduced all the way back at the end of 2012, before
OPAL was public. The #define for the OPAL call was introduced to the
Linux kernel in June 2013, and the call was never used in any kernel
tree ever (as far as we can find).
Thus, it's quite safe to remove this completely unused and completely
untested OPAL call.
Fixes: https://github.com/open-power/skiboot/issues/99
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'doc/opal-api')
-rw-r--r-- | doc/opal-api/index.rst | 5 | ||||
-rw-r--r-- | doc/opal-api/opal-pci-eeh-freeze-status-23.rst | 21 |
2 files changed, 25 insertions, 1 deletions
diff --git a/doc/opal-api/index.rst b/doc/opal-api/index.rst index 0da4b64..aa775b5 100644 --- a/doc/opal-api/index.rst +++ b/doc/opal-api/index.rst @@ -134,7 +134,8 @@ The OPAL API is the interface between an Operating System and OPAL. +---------------------------------------------+--------------+------------------------+----------+-----------------+ | :ref:`OPAL_PCI_NEXT_ERROR` | 60 | v1.0 (Initial Release) | POWER8 | | +---------------------------------------------+--------------+------------------------+----------+-----------------+ -| :ref:`OPAL_PCI_EEH_FREEZE_STATUS2` | 61 | v1.0 (Initial Release) | POWER8 | | +| :ref:`OPAL_PCI_EEH_FREEZE_STATUS2` | 61 | v1.0 (Initial Release) | POWER8 | Removed, never | +| | | | | used! | +---------------------------------------------+--------------+------------------------+----------+-----------------+ | :ref:`OPAL_PCI_POLL` | 62 | v1.0 (Initial Release) | POWER8 | | +---------------------------------------------+--------------+------------------------+----------+-----------------+ @@ -396,6 +397,8 @@ removed and no longer supported. +---------------------------------------------+-------+-----------------------+-----------------------+ | :ref:`OPAL_PCI_SET_PHB_TCE_MEMORY` | 12 | pre-v1.0 | :ref:`skiboot-5.2.0` | +---------------------------------------------+-------+-----------------------+-----------------------+ +| :ref:`OPAL_PCI_EEH_FREEZE_STATUS2` | 61 | v1.0 Initial Release | :ref:`skiboot-6.4` | ++---------------------------------------------+-------+-----------------------+-----------------------+ .. _OPAL_GET_COMPLETION_TOKEN_STATUS: diff --git a/doc/opal-api/opal-pci-eeh-freeze-status-23.rst b/doc/opal-api/opal-pci-eeh-freeze-status-23.rst index 035dc14..94b7245 100644 --- a/doc/opal-api/opal-pci-eeh-freeze-status-23.rst +++ b/doc/opal-api/opal-pci-eeh-freeze-status-23.rst @@ -36,6 +36,9 @@ OPAL_PCI_EEH_FREEZE_STATUS and this was safe. Supplying a pointer was previously *unsafe*. Always pass NULL. +.. note:: There once was a :ref:`OPAL_PCI_EEH_FREEZE_STATUS2` call, but it + was introduced in firmware and never used by any OS, so it has since + been removed from OPAL. Returns ------- @@ -48,3 +51,21 @@ Returns Hardware prohibited getting status, OPAL maybe marked it as broken. :ref:`OPAL_SUCCESS` Retreived status. + +.. _OPAL_PCI_EEH_FREEZE_STATUS2: + +OPAL_PCI_EEH_FREEZE_STATUS2 +=========================== + +.. code-block:: c + + #define OPAL_PCI_EEH_FREEZE_STATUS2 61 + +Use :ref:`OPAL_PCI_EEH_FREEZE_STATUS` instead of this (removed) call. + +While you'd think that a call introduced in the first public OPAL release would +have been used somewhere, it seems that all existing code has only ever used +:ref:`OPAL_PCI_EEH_FREEZE_STATUS` over :ref:`OPAL_PCI_EEH_FREEZE_STATUS2`. + +This call has been removed as of :ref:`skiboot-6.4` as it has literally never +been used. |