aboutsummaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorKamalesh Babulal <kamalesh@linux.vnet.ibm.com>2015-07-01 10:34:28 +0530
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-07-07 10:37:48 +1000
commit810c2e00bb4e0774c1331edc8f50def31efafc49 (patch)
tree8eda3bb2c1b3e3f93baad462aa7051ccb0c33748 /core
parent529cbf85745f6a99d44eacf76e0d9206af316979 (diff)
downloadskiboot-810c2e00bb4e0774c1331edc8f50def31efafc49.zip
skiboot-810c2e00bb4e0774c1331edc8f50def31efafc49.tar.gz
skiboot-810c2e00bb4e0774c1331edc8f50def31efafc49.tar.bz2
core/interrupts: Fix resource leak in add_opal_interrupts()
In add_opal_interrupts(), we allocate memory for irqs property. Which is not freed, after property is added. There are chances of irqs begin NULL, as free(NULL) is nop. It's harmless. Fixes Coverity defect#98849. Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'core')
-rw-r--r--core/interrupts.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/core/interrupts.c b/core/interrupts.c
index 9d79660..b91508f 100644
--- a/core/interrupts.c
+++ b/core/interrupts.c
@@ -191,6 +191,8 @@ void add_opal_interrupts(void)
* handling in Linux can cause problems.
*/
dt_add_property(opal_node, "opal-interrupts", irqs, count * 4);
+
+ free(irqs);
}
/*