aboutsummaryrefslogtreecommitdiff
path: root/core/test
diff options
context:
space:
mode:
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>2016-07-24 09:27:04 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2016-08-18 16:04:26 +1000
commitac3e90e1ef0aeab3faf2359ea77d130fade86548 (patch)
tree401026a1266ff821550d45ec411a5e6bf76f3730 /core/test
parentcd8e5c179461591e16d175132ff3446e70a8980d (diff)
downloadskiboot-ac3e90e1ef0aeab3faf2359ea77d130fade86548.zip
skiboot-ac3e90e1ef0aeab3faf2359ea77d130fade86548.tar.gz
skiboot-ac3e90e1ef0aeab3faf2359ea77d130fade86548.tar.bz2
check: Fix bugs in mem region tests
We shouldn't delete the list element after list_pop, it's already been deleted. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'core/test')
-rw-r--r--core/test/run-mem_region.c1
-rw-r--r--core/test/run-mem_region_init.c1
2 files changed, 0 insertions, 2 deletions
diff --git a/core/test/run-mem_region.c b/core/test/run-mem_region.c
index a24e736..6b7f6fb 100644
--- a/core/test/run-mem_region.c
+++ b/core/test/run-mem_region.c
@@ -249,7 +249,6 @@ int main(void)
mem_dump_free();
assert(i == 3);
while ((r = list_pop(&regions, struct mem_region, list)) != NULL) {
- list_del(&r->list);
lock(&skiboot_heap.free_list_lock);
mem_free(&skiboot_heap, r, __location__);
unlock(&skiboot_heap.free_list_lock);
diff --git a/core/test/run-mem_region_init.c b/core/test/run-mem_region_init.c
index d780ae5..17200c5 100644
--- a/core/test/run-mem_region_init.c
+++ b/core/test/run-mem_region_init.c
@@ -172,7 +172,6 @@ int main(void)
dt_free(dt_root);
while ((r = list_pop(&regions, struct mem_region, list)) != NULL) {
- list_del(&r->list);
if (r != &skiboot_code_and_text &&
r != &skiboot_heap &&
r != &skiboot_after_heap &&