opal: Deprecate reading the PHB status

The OPAL_PCI_EEH_FREEZE_STATUS call takes a bunch of parameters, one of
them is @phb_status. It is defined as __be64* and always NULL in
the current Linux upstream but if anyone ever decides to read that status,
then the PHB3's handler will assume it is struct OpalIoPhb3ErrorData*
(which is a lot bigger than 8 bytes) and zero it causing the stack
corruption; p7ioc-phb has the same issue.

This removes @phb_status from all eeh_freeze_status() hooks and moves
the error message from PHB4 to the affected OPAL handlers.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Reviewed-By: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/core/pci.c b/core/pci.c
index 14654d4..454b501 100644
--- a/core/pci.c
+++ b/core/pci.c
@@ -337,7 +337,7 @@ static void pci_check_clear_freeze(struct phb *phb)
 
 	/* Retrieve the frozen state */
 	rc = phb->ops->eeh_freeze_status(phb, pe_number, &freeze_state,
-					 &pci_error_type, &sev, NULL);
+					 &pci_error_type, &sev);
 	if (rc)
 		return;
 	if (freeze_state == OPAL_EEH_STOPPED_NOT_FROZEN)