diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-05-13 11:08:28 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-05-13 16:35:50 +1000 |
| commit | f7fa97c15ae443e051b3dfad57e183b05e400e04 (patch) | |
| tree | 6bf2c2b69449fc633e4a667ecac5eeb97edbc002 /asm | |
| parent | 9bdc9f540ec4886c6e5e78b8e5d7c67a9568ffa5 (diff) | |
| download | skiboot-f7fa97c15ae443e051b3dfad57e183b05e400e04.zip skiboot-f7fa97c15ae443e051b3dfad57e183b05e400e04.tar.gz skiboot-f7fa97c15ae443e051b3dfad57e183b05e400e04.tar.bz2 | |
Clarify documentation on OPAL parameters (up to 8), fix opal_entry
OpenPower ABI mentions (2.2.1.1 Register Roles) that r11 is not used for
parameter passing, and again in 2.2.3 (Parameter Passing in Registers)
that only 8 registers are available, with the rest spilling to stack.
Incorrectly, we had documented that we use r11 for a 9th parameter
and we were storing and loading r11 as part of OPAL_TRACE_ENTRY.
Github-issue: https://github.com/open-power/skiboot/issues/12
Reported-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Diffstat (limited to 'asm')
| -rw-r--r-- | asm/head.S | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -802,7 +802,7 @@ opal_boot_trampoline: * * r0: Token * r2: OPAL Base - * r3..r11: Args + * r3..r10: Args * r12: Scratch * r13..r31: Preserved * @@ -829,7 +829,6 @@ opal_entry: std %r8,STACK_GPR8(%r1) std %r9,STACK_GPR9(%r1) std %r10,STACK_GPR10(%r1) - std %r11,STACK_GPR11(%r1) #endif /* Save Token (r0), LR and r13 */ mflr %r12 @@ -869,7 +868,6 @@ opal_entry: ld %r8,STACK_GPR8(%r1) ld %r9,STACK_GPR9(%r1) ld %r10,STACK_GPR10(%r1) - ld %r11,STACK_GPR11(%r1) #endif /* OPAL_TRACE_ENTRY */ /* Convert our token into a table entry and get the |