aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Stanley <joel@jms.id.au>2015-06-22 15:04:54 +0930
committerStewart Smith <stewart@linux.vnet.ibm.com>2015-06-23 13:24:39 +1000
commit9f079336a342592e2823877f0477ac0a4eaa9f09 (patch)
treeb2857cb0b2bb994a361ff5c667d9570d9d81cbb6
parent6558adff01bbd35c8bfd3e50908253f837d2a293 (diff)
downloadskiboot-9f079336a342592e2823877f0477ac0a4eaa9f09.zip
skiboot-9f079336a342592e2823877f0477ac0a4eaa9f09.tar.gz
skiboot-9f079336a342592e2823877f0477ac0a4eaa9f09.tar.bz2
hw/ipmi-sel: Remove verbose SEL received message
This was useful in development when were diagnosing BMC issues. It's just noisy now, so drop it. We still print out the SEL received with the command and netfn as this may be useful in diagnosing failed reboots and power offs in the future. Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Alistair Popple <alistair@popple.id.au> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
-rw-r--r--hw/ipmi/ipmi-sel.c23
1 files changed, 3 insertions, 20 deletions
diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
index 7007f83..05ac977 100644
--- a/hw/ipmi/ipmi-sel.c
+++ b/hw/ipmi/ipmi-sel.c
@@ -253,40 +253,23 @@ static void sel_occ_reset(uint8_t sensor)
prd_occ_reset(chip);
}
-static void dump_sel(struct oem_sel *sel)
-{
- const int level = PR_DEBUG;
-
- prlog(level, "\tid %02x%02x\n", sel->id[0], sel->id[1]);
- prlog(level, "\ttype %02x\n", sel->type);
- prlog(level, "\tmanuf %02x %02x %02x\n",
- sel->manuf_id[0], sel->manuf_id[1], sel->manuf_id[2]);
- prlog(level, "\ttime %02x %02x %02x %02x\n",
- sel->timestamp[0], sel->timestamp[1],
- sel->timestamp[2], sel->timestamp[3]);
- prlog(level, "\tnetfun %02x\n", sel->netfun);
- prlog(level, "\tcmd %02x\n", sel->cmd);
- prlog(level, "\tdata %02x %02x %02x %02x\n", sel->data[0],
- sel->data[1], sel->data[2], sel->data[3]);
-}
-
void ipmi_parse_sel(struct ipmi_msg *msg)
{
struct oem_sel sel;
- prlog(PR_INFO, "SEL received (size: %d)\n", msg->resp_size);
assert(msg->resp_size <= 16);
memcpy(&sel, msg->data, msg->resp_size);
- dump_sel(&sel);
-
/* We do not process system event records */
if (sel.type == SEL_RECORD_TYPE_EVENT) {
prlog(PR_INFO, "IPMI: dropping System Event Record SEL\n");
return;
}
+ prlog(PR_DEBUG, "IPMI: SEL received (%d bytes, netfn %d, cmd %d)\n",
+ msg->resp_size, sel.netfun, sel.cmd);
+
/* Only accept OEM SEL messages */
if (sel.id[0] != SEL_OEM_ID_0 ||
sel.id[1] != SEL_OEM_ID_1 ||