diff options
| author | Cyril Bur <cyril.bur@au1.ibm.com> | 2018-01-15 16:18:00 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2018-01-30 20:42:38 -0600 |
| commit | 9b2136247e009fd0e82a88611095654f45ab0c79 (patch) | |
| tree | ee04842e3a4c822084cfa13c913c441134b810ad | |
| parent | a1e45fd2793cee5f75633f1fd862e2e2bb8a7197 (diff) | |
| download | skiboot-9b2136247e009fd0e82a88611095654f45ab0c79.zip skiboot-9b2136247e009fd0e82a88611095654f45ab0c79.tar.gz skiboot-9b2136247e009fd0e82a88611095654f45ab0c79.tar.bz2 | |
hdata/vpd: Remove possible dereference after null check (CID 207468)
The next_extry label doesn't do anything other than perform an addition
which requires a dereference of the NULL entry variable, just continue
the loop instead.
Fixes: 77190aa7 (hdata/vpd: Rework vpd node creation logic)
Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hdata/vpd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hdata/vpd.c b/hdata/vpd.c index 5562579..06a3b18 100644 --- a/hdata/vpd.c +++ b/hdata/vpd.c @@ -402,7 +402,7 @@ void dt_init_vpd_node(void) /* Get SLCA entry */ entry = slca_get_entry(index); if (!entry) - goto next_entry; + continue; /* * A child entry is valid if all of the following criteria is met |