diff options
| author | Andrew Jeffery <andrew@aj.id.au> | 2019-02-21 16:58:12 +1030 |
|---|---|---|
| committer | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2019-03-04 20:15:03 +0530 |
| commit | 041d61e2be1d9eb982151159a0979bf92f6a8356 (patch) | |
| tree | 58103dcfb8f383ada340d6c1dfed7ea95a3d9969 | |
| parent | 5c4b51a0408f767d0f5e130646d8bc932169a03d (diff) | |
| download | skiboot-041d61e2be1d9eb982151159a0979bf92f6a8356.zip skiboot-041d61e2be1d9eb982151159a0979bf92f6a8356.tar.gz skiboot-041d61e2be1d9eb982151159a0979bf92f6a8356.tar.bz2 | |
libflash/ipmi-hiomap: Remove unused close handling
[ Upstream commit 6d8bd2dd9eab3792d3aafde33d5573c0276b72b8 ]
Issuing a HIOMAP_C_CLOSE is not required by the protocol specification,
rather a close can be implicit in a subsequent
CREATE_{READ,WRITE}_WINDOW request. The implicit close provides an
opportunity to reduce LPC traffic and the implementation takes up that
optimisation, so remove the case from the IPMI callback handler.
Cc: stable
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
| -rw-r--r-- | libflash/ipmi-hiomap.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/libflash/ipmi-hiomap.c b/libflash/ipmi-hiomap.c index fdd12d5..7a36449 100644 --- a/libflash/ipmi-hiomap.c +++ b/libflash/ipmi-hiomap.c @@ -204,11 +204,6 @@ static void ipmi_hiomap_cmd_cb(struct ipmi_msg *msg) break; } - case HIOMAP_C_CLOSE_WINDOW: - lock(&ctx->lock); - ctx->window_state = closed_window; - unlock(&ctx->lock); - break; case HIOMAP_C_MARK_DIRTY: case HIOMAP_C_FLUSH: case HIOMAP_C_ACK: |