aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVasant Hegde <hegdevasant@linux.vnet.ibm.com>2018-10-23 10:35:26 -0400
committerStewart Smith <stewart@linux.ibm.com>2018-10-31 17:33:34 +1100
commit5e66c88ece463790439c99ed99c6e826447d4c15 (patch)
treef1bc34a06efd701d930f310fedf55dc6d3017bb6
parentafef7d5111787c8945bc0d8b3ad9e329f7e597c9 (diff)
downloadskiboot-5e66c88ece463790439c99ed99c6e826447d4c15.zip
skiboot-5e66c88ece463790439c99ed99c6e826447d4c15.tar.gz
skiboot-5e66c88ece463790439c99ed99c6e826447d4c15.tar.bz2
hdata/i2c: Skip unknown device type
commit c94b5a9e9c32724cba92e78073f6e3c334a0ad43 upstream. Do not add unknown I2C devices to device tree. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
-rw-r--r--hdata/i2c.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/hdata/i2c.c b/hdata/i2c.c
index c129d5e..6b797bc 100644
--- a/hdata/i2c.c
+++ b/hdata/i2c.c
@@ -322,14 +322,16 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,
* outdated or the device is marked as unknown (0xFF) in the
* hdat. Log both cases to see what/where/why.
*/
- if (!type || dev->type == 0xFF)
+ if (!type || dev->type == 0xFF) {
prlog(PR_WARNING, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
dev->dev_port, purpose, info->label);
- else
- prlog(PR_DEBUG, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
- dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
- dev->dev_port, purpose, info->label);
+ continue;
+ }
+
+ prlog(PR_DEBUG, "HDAT I2C: found e%dp%d - %s@%x dp:%02x (%#x:%s)\n",
+ dev->i2cm_engine, dev->i2cm_port, name, dev_addr,
+ dev->dev_port, purpose, info->label);
/*
* Multi-port device require special handling since we need to