diff options
| author | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2017-06-13 10:15:45 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-06-14 14:30:31 +1000 |
| commit | 807a3acc8fd66af1e1c6e7154aa5029c9b91bb3b (patch) | |
| tree | 1b993706bc66d72ebf36f09a5f8fdcdb00cfa467 | |
| parent | a34369631e6d85c26966eb0b8d5e4c44bcf96c7c (diff) | |
| download | skiboot-807a3acc8fd66af1e1c6e7154aa5029c9b91bb3b.zip skiboot-807a3acc8fd66af1e1c6e7154aa5029c9b91bb3b.tar.gz skiboot-807a3acc8fd66af1e1c6e7154aa5029c9b91bb3b.tar.bz2 | |
FSP: Improve timeout message
Presently we print word0 and word1 in error log. word0 contains
sequence number and command class. One has to understand word0
format to identify command class.
Lets explicitly print command class, sub command etc.
CC: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hw/fsp/fsp.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 162d9b4..4a8eaee 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -2168,8 +2168,8 @@ static void fsp_timeout_poll(void *data __unused) w1 = req->word1; mstate = req->state; prlog(PR_WARNING, "FSP: Response from FSP timed out," - " word0 = %x, word1 = %x state: %d\n", - w0, w1, mstate); + " cmd = %x subcmd = %x mod = %x state: %d\n", + w0 & 0xff, w1 & 0xff, (w1 >> 8) & 0xff, mstate); fsp_reg_dump(); fsp_cmdclass_resp_bitmask &= ~(1ull << index); cmdclass->timesent = 0; @@ -2180,8 +2180,9 @@ static void fsp_timeout_poll(void *data __unused) unlock(&fsp_lock); fsp_hir_reason_plid = log_simple_error( &e_info(OPAL_RC_FSP_POLL_TIMEOUT), - "FSP: Response from FSP timed out, word0 = %x," - "word1 = %x state: %d\n", w0, w1, mstate); + "FSP: Response from FSP timed out," + " cmd = %x subcmd = %x mod = %x state: %d\n", + w0 & 0xff, w1 & 0xff, (w1 >> 8) & 0xff, mstate); } next_bit: cmdclass_resp_bitmask = cmdclass_resp_bitmask >> 1; |