diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-07-04 15:12:24 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-07-04 15:13:58 +1000 |
| commit | 5a6fa8e00612c1c8e02cf5279d944c07a0f005c7 (patch) | |
| tree | 15ef88662f1619a3e4bbddf6e102cfded1077a22 | |
| parent | ef37b478a0a32fa4d715008c2c1ba1a4b015e740 (diff) | |
| download | skiboot-5a6fa8e00612c1c8e02cf5279d944c07a0f005c7.zip skiboot-5a6fa8e00612c1c8e02cf5279d944c07a0f005c7.tar.gz skiboot-5a6fa8e00612c1c8e02cf5279d944c07a0f005c7.tar.bz2 | |
core/mem_region: check return value of add_region
The only sensible thing to do if this fails is to abort() as we've
likely just failed reserving reserved memory regions, and nothing
good comes from that.
Found by static analysis
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | core/mem_region.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/core/mem_region.c b/core/mem_region.c index 8d1363f..77324d7 100644 --- a/core/mem_region.c +++ b/core/mem_region.c @@ -1,4 +1,4 @@ -/* Copyright 2013-2014 IBM Corp. +/* Copyright 2013-2017 IBM Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -947,7 +947,10 @@ static void mem_region_parse_reserved_properties(void) dt_get_number(range, 2), dt_get_number(range + 1, 2), NULL, REGION_FW_RESERVED); - add_region(region); + if (!add_region(region)) { + prerror("Couldn't add mem_region %s\n", name); + abort(); + } } } else if (names || ranges) { prerror("Invalid properties: reserved-names=%p " |