diff options
| author | Cédric Le Goater <clg@kaod.org> | 2020-09-29 13:41:49 +0200 |
|---|---|---|
| committer | Oliver O'Halloran <oohall@gmail.com> | 2020-11-02 12:37:01 +1100 |
| commit | a7540bd63ac684541938b0d807a257341d95130d (patch) | |
| tree | 9838f564dd309b0b7e69e3ae447bae76d54dc5e7 | |
| parent | 37d26e2e17e9e055a6b781beb558beeb22d4ae2f (diff) | |
| download | skiboot-a7540bd63ac684541938b0d807a257341d95130d.zip skiboot-a7540bd63ac684541938b0d807a257341d95130d.tar.gz skiboot-a7540bd63ac684541938b0d807a257341d95130d.tar.bz2 | |
phb4: Finish removing P9 DD1 workaround on LSIs
Commit ad7e9a67c4e4 ("xive/p9: obsolete OPAL_XIVE_IRQ_SHIFT_BUG
flags") forgot to remove the internal flag.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
| -rw-r--r-- | hw/phb4.c | 5 | ||||
| -rw-r--r-- | include/xive.h | 1 |
2 files changed, 1 insertions, 5 deletions
@@ -5882,12 +5882,9 @@ static void phb4_create(struct dt_node *np) xive_register_hw_source(p->base_msi, p->num_irqs - 8, 16, p->int_mmio, irq_flags, NULL, NULL); - /* XIVE_SRC_SHIFT_BUG is a DD1 workaround */ xive_register_hw_source(p->base_lsi, 8, 16, p->int_mmio + ((p->num_irqs - 8) << 16), - XIVE_SRC_LSI | XIVE_SRC_SHIFT_BUG, - p, - &phb4_lsi_ops); + XIVE_SRC_LSI, p, &phb4_lsi_ops); /* Platform additional setup */ if (platform.pci_setup_phb) diff --git a/include/xive.h b/include/xive.h index fb8967e..477d380 100644 --- a/include/xive.h +++ b/include/xive.h @@ -41,7 +41,6 @@ __attrconst uint32_t xive_get_notify_base(uint32_t girq); #define XIVE_SRC_EOI_PAGE1 0x02 /* EOI on the second page */ #define XIVE_SRC_STORE_EOI 0x04 /* EOI using stores supported */ #define XIVE_SRC_LSI 0x08 /* Interrupt is an LSI */ -#define XIVE_SRC_SHIFT_BUG 0x10 /* ESB update offset << 4 (PHB4 LSI DD1) */ struct irq_source_ops; void xive_register_hw_source(uint32_t base, uint32_t count, uint32_t shift, |