diff options
| author | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2020-10-19 17:14:08 +0530 |
|---|---|---|
| committer | Oliver O'Halloran <oohall@gmail.com> | 2020-10-21 15:06:27 +1100 |
| commit | 9ca8bf1bde56330075634bd3cb601d0f6ee90514 (patch) | |
| tree | 28cad47db81590ea96724dfb94cf0cd6370de2e9 | |
| parent | c214b6e8baf596050ea8b18eec7abb0cf397d51a (diff) | |
| download | skiboot-9ca8bf1bde56330075634bd3cb601d0f6ee90514.zip skiboot-9ca8bf1bde56330075634bd3cb601d0f6ee90514.tar.gz skiboot-9ca8bf1bde56330075634bd3cb601d0f6ee90514.tar.bz2 | |
FSP/NVRAM: Do not assert in vNVRAM statistics call
`msg` is valid pointer here. I don't recall why I added assert here :-(
This is not correct. We shouldn't call assert here. Also we are not using
`msg`. Hence convert it to `__unused`.
Fixes: 19d4f98e ('FSP/NVRAM: Handle "get vNVRAM statistics" command')
Cc: skiboot-stable@lists.ozlabs.org # v5.4.x +
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Reviewed-by: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
| -rw-r--r-- | hw/fsp/fsp-nvram.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/fsp/fsp-nvram.c b/hw/fsp/fsp-nvram.c index 80c8424..aa17cb5 100644 --- a/hw/fsp/fsp-nvram.c +++ b/hw/fsp/fsp-nvram.c @@ -305,12 +305,11 @@ static struct fsp_client fsp_nvram_client_rr = { .message = fsp_nvram_msg_rr, }; -static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg) +static bool fsp_vnvram_msg(u32 cmd_sub_mod, struct fsp_msg *msg __unused) { u32 cmd; struct fsp_msg *resp; - assert(msg == NULL); switch (cmd_sub_mod) { case FSP_CMD_GET_VNV_STATS: prlog(PR_DEBUG, |