diff options
| author | Mukesh Ojha <mukesh02@linux.vnet.ibm.com> | 2016-09-07 15:51:17 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-10-25 20:12:51 +1100 |
| commit | ee1bbae31c50bdc260a0d3e0eed33114155f0044 (patch) | |
| tree | 70cd9b0212415928983b0ff0cfca19ba1fac56db | |
| parent | 6e1a11461d112ef0c7dbde0166a27b57fe17a115 (diff) | |
| download | skiboot-ee1bbae31c50bdc260a0d3e0eed33114155f0044.zip skiboot-ee1bbae31c50bdc260a0d3e0eed33114155f0044.tar.gz skiboot-ee1bbae31c50bdc260a0d3e0eed33114155f0044.tar.bz2 | |
errorlog: Removal of elog_reject_head() from 'opal_kexec_elog_notify' routine
elog_reject_head() routine makes the state 'elog_read_from_fsp_head_state'
either 'ELOG_STATE_REJECTED' or 'ELOG_STATE_NONE' depending on the current
state of 'elog_read_from_fsp_head_state'.
We can remove this elog_reject_head() from 'opal_kexec_elog_notify()' as just
after that it is called inside 'fsp_opal_resend_pending_logs()'. So, it is
redundant inside opal_kexec_elog_notify() routine.
Signed-off-by: Mukesh Ojha <mukesh02@linux.vnet.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hw/fsp/fsp-elog-read.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/fsp/fsp-elog-read.c b/hw/fsp/fsp-elog-read.c index ec5316e..fb8c753 100644 --- a/hw/fsp/fsp-elog-read.c +++ b/hw/fsp/fsp-elog-read.c @@ -479,7 +479,6 @@ static void fsp_opal_resend_pending_logs(void) static bool opal_kexec_elog_notify(void *data __unused) { lock(&elog_read_lock); - elog_reject_head(); elog_enabled = false; opal_update_pending_evt(OPAL_EVENT_ERROR_LOG_AVAIL, 0); unlock(&elog_read_lock); |