aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2016-10-26 18:06:21 +1100
committerStewart Smith <stewart@linux.vnet.ibm.com>2016-10-28 10:52:21 +1100
commitc25007d0d884ed358cbd7f06e5047bbebad9598f (patch)
tree56aec5b7216009e91740cd8741d769ce413cd214
parentd13f451dc5efe274ab30ecfd040c209c23b6afc1 (diff)
downloadskiboot-c25007d0d884ed358cbd7f06e5047bbebad9598f.zip
skiboot-c25007d0d884ed358cbd7f06e5047bbebad9598f.tar.gz
skiboot-c25007d0d884ed358cbd7f06e5047bbebad9598f.tar.bz2
flash-subpartition: fix spurious non-NULL check of non-NULL variable
In flash_subpart_info, part_actual can't be NULL (we bail out if so), so this spurious check just manages to trigger warning in static analysis. Fixes: 8652ced003f7977e1126149b8011c184b88fe24e Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
-rw-r--r--core/flash-subpartition.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/core/flash-subpartition.c b/core/flash-subpartition.c
index 1e91c1b..0de7b4e 100644
--- a/core/flash-subpartition.c
+++ b/core/flash-subpartition.c
@@ -106,8 +106,6 @@ int flash_subpart_info(void *part_header, uint32_t header_len,
*offset += o;
if (size)
*size = s;
- if (!part_actual)
- return OPAL_SUCCESS;
subpart_found = true;
}
toc += sizeof(struct flash_hostboot_toc);