diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-11-11 14:38:12 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-01-21 15:24:55 +1100 |
| commit | fa02201afc2e6e986ca034180d0631adeb3ae817 (patch) | |
| tree | 3edd5a68f7518116b1e73009dccc0af92824ff6f | |
| parent | 3ee7ca100e2068d69b750d77568957efffe7178f (diff) | |
| download | skiboot-fa02201afc2e6e986ca034180d0631adeb3ae817.zip skiboot-fa02201afc2e6e986ca034180d0631adeb3ae817.tar.gz skiboot-fa02201afc2e6e986ca034180d0631adeb3ae817.tar.bz2 | |
Use VALGRIND callout rather than tricky malloc/memcpy
commit d04030556db4bb73151172ded3f279882e706dbd upstream
The tricky memcpy trips up various static analysers and looks rather
odd. The more correct thing to do is to ask valgrind to mark it
as undefined. There's a call for that, and we depend on valgrind
to run the test suite anyway, so we're not introducing a new
dependency.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hdata/test/hdata_to_dt.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hdata/test/hdata_to_dt.c b/hdata/test/hdata_to_dt.c index 9d23f33..9e5abf8 100644 --- a/hdata/test/hdata_to_dt.c +++ b/hdata/test/hdata_to_dt.c @@ -25,6 +25,8 @@ #include <interrupts.h> +#include <valgrind/memcheck.h> + struct dt_node *opal_node; /* Our actual map. */ @@ -138,9 +140,7 @@ static void dump_val(unsigned indent, const void *prop, size_t size) /* Make sure valgrind knows these are undefined bytes. */ static void undefined_bytes(void *p, size_t len) { - void *undef = malloc(len); - memcpy(p, undef, len); - free(undef); + VALGRIND_MAKE_MEM_UNDEFINED(p, len); } static void dump_dt(const struct dt_node *root, unsigned indent) |