diff options
| author | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2014-12-09 21:55:12 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2014-12-10 11:50:33 +1100 |
| commit | 1725d94f2638fabd1b90d69247665c0e05b75c27 (patch) | |
| tree | 48a5854385044cfeb15caa86d2be1dc76d3f105f | |
| parent | 1c732e3184f0fae0b598be713a386df7d274d48f (diff) | |
| download | skiboot-1725d94f2638fabd1b90d69247665c0e05b75c27.zip skiboot-1725d94f2638fabd1b90d69247665c0e05b75c27.tar.gz skiboot-1725d94f2638fabd1b90d69247665c0e05b75c27.tar.bz2 | |
FSP/EPOW: Fix unused result warnings in EPOW driver
Commit c36c5607 added warn_unused_result compilation flag to
fsp_queue_msg function....which resulted in multiple warnings
in EPOW driver. This patch fixes those warnings.
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | hw/fsp/fsp-epow.c | 37 |
1 files changed, 34 insertions, 3 deletions
diff --git a/hw/fsp/fsp-epow.c b/hw/fsp/fsp-epow.c index 0012dbc..3979bb2 100644 --- a/hw/fsp/fsp-epow.c +++ b/hw/fsp/fsp-epow.c @@ -148,6 +148,7 @@ static void fsp_epow_update(u8 *epow, int epow_type) /* Process captured EPOW event notification */ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) { + struct fsp_msg *resp; u8 epow[8]; /* Basic EPOW signature */ @@ -174,15 +175,45 @@ static void fsp_process_epow(struct fsp_msg *msg, int epow_type) */ switch(epow_type) { case EPOW_NORMAL: - fsp_queue_msg(fsp_mkmsg(FSP_CMD_STATUS_REQ, 0), fsp_freemsg); + resp = fsp_mkmsg(FSP_CMD_STATUS_REQ, 0); + if (resp == NULL) { + prerror(PREFIX "%s : Message allocation failed\n", + __func__); + break; + } + if (fsp_queue_msg(resp, fsp_freemsg)) { + fsp_freemsg(resp); + prerror(PREFIX "%s : Failed to queue response " + "message\n", __func__); + } break; case EPOW_EX1: /* EPOW_EX1 specific extra event data */ epow[4] = msg->data.bytes[4]; - fsp_queue_msg(fsp_mkmsg(FSP_CMD_STATUS_EX1_REQ, 0), fsp_freemsg); + resp = fsp_mkmsg(FSP_CMD_STATUS_EX1_REQ, 0); + if (resp == NULL) { + prerror(PREFIX "%s : Message allocation failed\n", + __func__); + break; + } + if (fsp_queue_msg(resp, fsp_freemsg)) { + fsp_freemsg(resp); + prerror(PREFIX "%s : Failed to queue response " + "message\n", __func__); + } break; case EPOW_EX2: - fsp_queue_msg(fsp_mkmsg(FSP_CMD_STATUS_EX2_REQ, 0), fsp_freemsg); + resp = fsp_mkmsg(FSP_CMD_STATUS_EX2_REQ, 0); + if (resp == NULL) { + prerror(PREFIX "%s : Message allocation failed\n", + __func__); + break; + } + if (fsp_queue_msg(resp, fsp_freemsg)) { + fsp_freemsg(resp); + prerror(PREFIX "%s : Failed to queue response " + "message\n", __func__); + } break; default: prlog(PR_WARNING, PREFIX "Unknown EPOW event notification\n"); |