diff options
| author | Ananth N Mavinakayanahalli <ananth@in.ibm.com> | 2014-08-14 13:06:29 +0530 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2014-08-15 14:36:38 +1000 |
| commit | 0890debca7cdd9a78ca2d6d52e07609404412818 (patch) | |
| tree | 3f4fca1cc877fa927b3f35d0f145da35e3b83de9 | |
| parent | 39e53e483b186122db12712aca5dfb666e819729 (diff) | |
| download | skiboot-0890debca7cdd9a78ca2d6d52e07609404412818.zip skiboot-0890debca7cdd9a78ca2d6d52e07609404412818.tar.gz skiboot-0890debca7cdd9a78ca2d6d52e07609404412818.tar.bz2 | |
SURV: Trigger HIR on surv sysparam query error
For the case where the survserver on the fsp server is dead (for whatever
reason [1]), even before the first time query via sysparam of the surv
status by sapphire, we get an error response to the sysparam query.
We should apparently trigger a HIR in that case (same as phyp).
[1] survserver has a real bug on a 'fsptelinit --disablerecovery'
followed by a 'kill -9 <survserver_pid>'
Fixes https://bugzilla.linux.ibm.com/show_bug.cgi?id=114646.
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Signed-off-by: Jeremy Kerr <jeremy.kerr@au.ibm.com>
| -rw-r--r-- | hw/fsp/fsp-surveillance.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c index 9ac04a6..a811889 100644 --- a/hw/fsp/fsp-surveillance.c +++ b/hw/fsp/fsp-surveillance.c @@ -134,8 +134,9 @@ static void fsp_surv_got_param(uint32_t param_id __unused, int err_len, { if (err_len != 4) { log_simple_error(&e_info(OPAL_RC_SURVE_STATUS), - "SURV: Error retreiving surveillance status: %d\n", + "SURV: Error (%d) retrieving surv status; initiating R/R\n", err_len); + fsp_trigger_reset(); return; } |