aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2020-09-08smbios: avoid integer overflow when adding SMBIOS type 0 tableDaniel P. Berrangé1-4/+10
SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a maximum length of 0xffff. If the SMBIOS data received from QEMU is large enough, then adding the type 0 table will cause integer overflow. This results in fun behaviour such as KVM crash, or hangs in SeaBIOS. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2020-07-28nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5Paul Menzel1-1/+1
Currently, setting SeaBIOS debug level to 3, the log is filled with messages like below. ns 1 read lba 11346288+8: 0 ns 1 read lba 11346296+4: 0 ns 1 read lba 11346300+4: 0 ns 1 read lba 11346304+8: 0 ns 1 read lba 11346312+8: 0 ns 1 read lba 11346320+8: 0 ns 1 read lba 11346328+8: 0 ns 1 read lba 11346336+8: 0 With SeaBIOS as coreboot payload, this fills up the CBMEM console buffer. So, increase the debug level to 5, so possible console buffer do not overflow. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
2020-07-28virtio-scsi: fix boot prio detection by using correct lunStefan Reiter1-3/+3
Commits d6bdb85eb0 virtio-scsi: skip initializing non-bootable devices f82e82a5ab2 virtio-mmio: add support for scsi devices. both use the lun value from tmpl_drv, which is always 0, instead of the correct one passed as a separate parameter. This causes systems where LUNs other than 0 are set as bootable, but 0 is not, to not boot. Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-06-26timer: Handle decrements of PIT counterRoman Bolshakov1-1/+1
There's a fallback to PIT if TSC is not present but it doesn't work properly. It prevents boot from floppy on isapc and 486 cpu [1][2]. SeaBIOS configures PIT in Mode 2. PIT counter is decremented in the mode but timer_adjust_bits() thinks that the counter overflows and increases 32-bit tick counter on each detected "overflow". Invalid overflow detection results in 55ms time advance (1 / 18.2Hz) on each read from PIT counter. So all timers expire much faster and 5-second floppy timeout expires in 83 real microseconds (or just a bit longer). It can be fixed by making the counter recieved from PIT an increasing value so it can be passed to timer_adjust_bits(): 0, 1, 2 and up to 65535 and then the counter is re-loaded with 0. 1. https://bugs.launchpad.net/seabios/+bug/1840719 2. https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg03924.html Fixes: eac11944019 ("Unify pmtimer_read() and pittimer_read() code.") Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
2020-06-24serialio: Preserve Xen DebugOutputPortJason Andryuk1-0/+4
xen_preinit() runs early and changes DebugOutputPort. qemu_preinit() runs soon after. inb on DebugOutputPort doesn't work on Xen, so the check will always fail and DebugOutputPort will be cleared to 0 disabling output. Quick exit the function when running on Xen to preserve the modified DebugOutputPort. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
2020-05-25pci: fix mmconfig supportGerd Hoffmann1-6/+6
The MODESEGMENT condition is backwards, with the effect that mmconfig mode is not used to configure pci bars during POST. Oops. Fix it. The only real mode pci config space access seems to come from the ipxe option rom initialiation. Which happens to work via mmconfig because it runs in big real mode so this went unnoticed ... Fixes: 6a3b59ab9c7d ("pci: add mmconfig support") Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-24boot: Fixup check for only one item in boot listKevin O'Connor1-8/+9
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
2020-05-24boot: Fix logic for boot menu displayMatt DeVillier1-1/+1
Commit c61193d3 [boot: Extend `etc/show-boot-menu`...] changed the logic surrounding the use of show_boot_menu incorrectly, leading the boot menu to be skipped by default with no way to override. Correct the logic error so that show_boot_menu works as documented. Test: build/boot SeaBIOS, verify boot menu option shown by default. Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
2020-05-21Revert "ps2port: adjust init routine to fix PS/2 keyboard issues"Kevin O'Connor1-13/+5
It is believed that the underlying problem was fixed in commit dbf9dd27f and therefore this commit is not necessary. This reverts commit bfdb3f86e9116fc79ce63c231373b084aad11218. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
2020-05-21cdrom: Demote `scsi_is_ready` return print to debug levelPaul Menzel1-1/+1
Printing the return value of `scsi_is_ready()` is a debug message, so change the log level from 1 to 5. Booting from DVD/CD... Device reports MEDIUM NOT PRESENT scsi_is_ready returned -1 Boot failed: Could not read from CDROM (code 0003) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
2020-05-21boot: Log, if boot menu is skippedPaul Menzel1-0/+1
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
2020-05-21boot: Extend `etc/show-boot-menu` to configure skipping boot menu with only ↵Paul Menzel1-2/+3
one device Concerns were raised, that skipping the boot menu, if only one device is present, might make debugging issues more difficult. So, extend the current runtime configuration option `etc/show-boot-menu` to enable this feature by setting it to 2. Fixes: 29ee1fb8 ("Skip boot menu and timeout with only one boot device") Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
2020-05-15acpi: find and register virtio-mmio devicesGerd Hoffmann3-0/+23
Seach for virtio-mmio devices in the DSDT table, register the devices found. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15acpi: skip kbd init if not presentGerd Hoffmann1-0/+4
Don't initialize the ps/2 keyboard in case the device is not listed in the ACPi DSDT table. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15acpi: add dsdt parserGerd Hoffmann5-2/+690
Create a list of devices found in the DSDT table. Add helper functions to find devices, walk the list and figure device informations like mmio ranges and irqs. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15acpi: add xsdt supportGerd Hoffmann2-10/+41
In case a xsdt table is present (and located below 4G) prefer it over rsdt. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15virtio-mmio: print device typeGerd Hoffmann1-2/+19
2020-05-15virtio-mmio: add support for block devices.Gerd Hoffmann5-1/+84
Add and use bootprio_find_mmio_device() to figure the boot priority of virtio-mmio block devices. Add init_virtio_blk_mmio to initialize one virtio-mmio block device. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15virtio-mmio: add support for scsi devices.Gerd Hoffmann5-12/+76
Add new fields to struct virtio_lun_s for mmio support, add mmio parameter to virtio_scsi_init_lun(), so both pci and mmio devices can be handled. Add and use bootprio_find_scsi_mmio_device() to figure boot priority of devices connected to a virtio-mmio scsi controller. Finally add init_virtio_scsi_mmio() to initialize one virtio-mmio scsi controller. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15virtio-mmio: add support to vp_*() functionsGerd Hoffmann1-11/+57
Add support for virtio-mmio to the vp_*() helper functions. Both legacy and 1.0 virto-mmio versions are supported. They are very simliar anyway, only the virtqueue initialization is slightly different. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15virtio-mmio: device probing and initialization.Gerd Hoffmann3-0/+135
Add virtio_mmio_setup_one() to setup virtio mmio devices. Add vp_init_mmio() to initialize device struct. Because virtio-pci and virtio-mmio are quite simliar we reuse the infrastructure we already have for virtio-pci and just setup struct vp_cap for virtio-mmio. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15qemu: check rtc presence before reading cpu count from cmosGerd Hoffmann1-3/+10
Read month register which should never have a value larger than 12. In case the read returns 0xff assume the rtc isn't there. Don't try to read the cpu count from cmos without rtc. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
2020-05-15qemu: rework e820 detectionGerd Hoffmann1-51/+82
Read e820 table from fw_cfg early. This avoids reading the cmos for ram detection on modern qemu. It also simplifies the ram detection logic. We stop doing ram detecion in two steps, so we don't have to worry about the second step overwriting the setup done by the first step. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-05-15qemu: factor out qemu_cfg_detect()Gerd Hoffmann1-4/+14
Move qemu fw_cfg detection to separate function. No functional change. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-04-19tcgbios: Add support for SHA3 type of algorithmsStefan Berger2-3/+28
Add support for SHA3 type of algorithms that a TPM2 may support some time in the future. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2020-04-19tcgbios: Fix the vendorInfoSize to be of type u8Stefan Berger1-2/+2
The vendorInfoSize is a u8 rather than a u32. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2020-04-19tcgbios: Only write logs for PCRs that are in active PCR banksStefan Berger1-8/+22
Only write the logs for those PCRs that are in active PCR banks. A PCR banks is assumed to be active if any of the BIOS relevant PCRs 0 - 7 is enabled, thus pcrSelect[0] != 0. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2020-03-27pci: add mmconfig supportGerd Hoffmann3-12/+54
Add support for pci config space access via mmconfig bar. Enable for qemu q35 chipset. Main advantage is that we need only one instead of two io operations per config space access, which translates to one instead of two vmexits for virtualization. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200323145911.22319-3-kraxel@redhat.com
2020-03-27pci: factor out ioconfig_cmd()Gerd Hoffmann1-6/+11
Add helper function to calculate PORT_PCI_CMD value from bdf + addr. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200323145911.22319-2-kraxel@redhat.com
2020-03-20std/tcg: Replace zero-length array with flexible-array memberPaul Menzel1-1/+1
GCC 10 gives the warnings below: In file included from out/ccode32flat.o.tmp.c:54: ./src/tcgbios.c: In function 'tpm20_write_EfiSpecIdEventStruct': ./src/tcgbios.c:290:30: warning: array subscript '(<unknown>) + 4294967295' is outside the bounds of an interior zero-length array 'struct TCG_EfiSpecIdEventAlgorithmSize[0]' [-Wzero-length-bounds] 290 | event.hdr.digestSizes[count].algorithmId = be16_to_cpu(sel->hashAlg); | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ In file included from ./src/tcgbios.c:22, from out/ccode32flat.o.tmp.c:54: ./src/std/tcg.h:527:7: note: while referencing 'digestSizes' 527 | } digestSizes[0]; | ^~~~~~~~~~~ In file included from out/ccode32flat.o.tmp.c:54: ./src/tcgbios.c:291:30: warning: array subscript '(<unknown>) + 4294967295' is outside the bounds of an interior zero-length array 'struct TCG_EfiSpecIdEventAlgorithmSize[0]' [-Wzero-length-bounds] 291 | event.hdr.digestSizes[count].digestSize = hsize; | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ In file included from ./src/tcgbios.c:22, from out/ccode32flat.o.tmp.c:54: ./src/std/tcg.h:527:7: note: while referencing 'digestSizes' 527 | } digestSizes[0]; | ^~~~~~~~~~~ [Description copied from Gustavo A. R. Silva <gustavo@embeddedor.com> from his Linux kernel commits.] The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member [1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76497732932f15e7323dc805e8ea8dc11bb587cf Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
2020-03-17ps2port: adjust init routine to fix PS/2 keyboard issuesMatt DeVillier1-5/+13
PS/2 keyboards on Chromebooks with upstream coreboot + SeaBIOS often fail to init properly / register keystrokes. Modify ps2port init to match that of TianoCore, which doesn't have said issues. Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Message-Id: <248435f9-c169-e1db-fc3e-62185b74899c@molgen.mpg.de> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-03-17Skip boot menu and timeout with only one boot deviceMatt DeVillier1-0/+6
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Message-Id: <45aa3ebe-b97c-f1af-2901-ec4e9bcd1084@molgen.mpg.de> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-03-17sercon: vbe modeset is int 10h function 4f02 not 4f00Gerd Hoffmann1-1/+1
Fixes console redirection for NetBSD primary bootloader. https://bugs.launchpad.net/bugs/1743191 Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Kevin O'Connor <kevin@koconnor.net> Message-Id: <20200306090321.24811-1-kraxel@redhat.com>
2020-03-16kvm: add support for reading tsc frequency from kvmclockGerd Hoffmann2-0/+56
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200310102248.28412-4-kraxel@redhat.com
2020-03-16kvm: add support for reading tsc frequency via cpuid.Gerd Hoffmann1-0/+5
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200310102248.28412-3-kraxel@redhat.com
2020-03-16kvm: detect unconditionallyGerd Hoffmann1-7/+1
So we detect kvm even in case there is no qemu pci hostbridge present, for example when using the new, pci-less microvm machine type. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200310102248.28412-2-kraxel@redhat.com
2020-03-16timer: add tsctimer_setfreq()Gerd Hoffmann2-1/+26
Add function to set tsc frequency directly, without calibration. Also tweak timer setup functions a bit: skip setup in case TimerPort has not the default value any more, i.e. another timer has been setup already. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Message-id: 20200310102248.28412-1-kraxel@redhat.com
2020-03-06hw/usb-hid: Don't abort if setting key repeat rate failsMatt DeVillier1-1/+1
Since the USB stack doesn't handle stalled pipes, don't abort keyboard setup if the set_idle command fails, since it's a non-critical feature. Instead, log a warning. Test: build/boot Google Pixel Slate, observe keyboard functional Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
2020-03-06usb-hid: Improve max packet size checkingKevin O'Connor1-22/+33
Some USB keyboards report 9 or 10-byte max packet sizes instead of the 8-byte max specified by the USB HID spec. Increase the available size and simplify the boundary checks. Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
2020-01-14nvme: skip initializing non-bootable devicesGerd Hoffmann1-0/+7
Check NVMe devices whenever they are bootable, skip initialization in case they are not. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-01-14virtio-scsi: skip initializing non-bootable devicesGerd Hoffmann1-1/+10
Check each disk attached to a virtio-scsi device whenever it is bootable and skip initialization in case it isn't. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-01-14boot: cache HALT priorityGerd Hoffmann1-1/+5
Call find_prio("HALT") only once, on first is_bootprio_strict() call. Store the result in a variable and reuse it on subsequent calls. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-01-14virtio: Do not init non-bootable devicesAlexey Kirillov2-2/+20
Because initializing a virtio-blk or virtio-scsi device requires a large amount of memory, you cannot create more than about 10 virtio devices. Since initialization is required for booting from media, we will not initialize those devices that are not in the boot order list. Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru> Message-id: 20200107171917.7535-3-lekiravi@yandex-team.ru Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-01-14boot: Detect strict boot order (HALT record) in functionAlexey Kirillov2-0/+6
Introduce is_bootprio_strict(). We will reuse this function in the next commit. Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru> Message-id: 20200107171917.7535-2-lekiravi@yandex-team.ru Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2019-11-18geometry: Apply LCHS values for boot devicesSam Eiderman11-1/+39
Boot devices which use overriden LCHS values are: * ata * ahci * scsi * esp * lsi * megasas * mpt * pvscsi * virtio * virtio-blk We use these values in get_translation() and setup_translation() by introducing a new translation type: "TRANSLATION_HOST". We treat this translation as TRANSLATION_NONE in fill_ata_edd(), although this does not really matter since now the translation between physical and logical geometry does not exist. Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com> Message-Id: <20190626123816.8907-6-shmuel.eiderman@oracle.com>
2019-11-18geometry: Add boot_lchs_find_*() utility functionsSam Eiderman3-0/+82
Adding the following utility functions: * boot_lchs_find_pci_device * boot_lchs_find_scsi_device * boot_lchs_find_ata_device These will be used to apply LCHS values received through fw_cfg. Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com> Message-Id: <20190626123816.8907-5-shmuel.eiderman@oracle.com>
2019-11-18boot: Build ata and scsi paths in functionSam Eiderman1-8/+28
Introduce build_scsi_path() and build_ata_path(). We will reuse these functions in the next commit. Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com> Message-Id: <20190626123816.8907-4-shmuel.eiderman@oracle.com>
2019-11-18geometry: Read LCHS from fw_cfgSam Eiderman1-0/+74
Read bios geometry for boot devices from fw_cfg. By receiving LCHS values directly from QEMU through fw_cfg we will be able to support logical geometries which can not be inferred by SeaBIOS itself. (For instance: A 8GB virtio-blk hard drive which was originally created as an IDE and must report LCHS of */32/63 for its operating system to function will always break under SeaBIOS since a LARGE/LBA translation will be used, causing the number of reported logical heads to be > 32.) The only LCHS paravirtual interface available at the moment is for IDE disks (rtc_read() in get_translation()) and it's limited to a maximum of 4 disks (this code existed in SeaBIOS's translation function before SCSI and VirtIO were even introduced). This is why we create a new interface which allows passing LCHS information per hdd. Boot device information is serialized in the following way: * device_path lcyls lheads lsecs\n ... * device_path lcyls lheads lsecs\0 Device path is a null terminated string in the "Open Firmware" device path format, the same path as used in bootorder. Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com> Message-Id: <20190626123816.8907-2-shmuel.eiderman@oracle.com>
2019-11-18Revert "geometry: Read LCHS from fw_cfg"Gerd Hoffmann1-87/+0
This reverts commit 7c66a439c07536b525ff9d5ce230775975e9c072.
2019-11-18Revert "geometry: Add boot_lchs_find_*() utility functions"Gerd Hoffmann2-88/+0
This reverts commit ad2910949b1886deba24f574cee76cdc75e7cabe.
generated by cgit v1.1 at 2025-09-18 17:00:16 +0000