From 32e2968a1ec05c2631b707ab2175aa25987e3896 Mon Sep 17 00:00:00 2001 From: Cindy Kuo Date: Tue, 16 Apr 2024 13:02:36 +0800 Subject: SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735 Should not call HiiGetBrowserData() and HiiSetBrowserData() in ACTION_FORM_OPEN callback function. Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData which have been used by OpalHii.c. Change callback action from FORM_OPEN to RETRIEVE to meet UEFI spec. Cc: Jiewen Yao Cc: Rahul Kumar Cc: Dandan Bi Cc: Ming Tan Cc: Arthur Chen Cc: Xiao X Chen Cc: Tina Chen Signed-off-by: CindyX Kuo Reviewed-by: Dandan Bi Reviewed-by: Tina Chen Acked-by: Jiewen Yao --- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'SecurityPkg') diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c index 8035f44..56ada1a 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c @@ -632,7 +632,7 @@ DriverCallback ( HiiKey.Raw = QuestionId; HiiKeyId = (UINT8)HiiKey.KeyBits.Id; - if (Action == EFI_BROWSER_ACTION_FORM_OPEN) { + if (Action == EFI_BROWSER_ACTION_RETRIEVE) { switch (HiiKeyId) { case HII_KEY_ID_VAR_SUPPORTED_DISKS: DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SUPPORTED_DISKS\n")); -- cgit v1.1