From 6a1f06fadb26c342205cf9edeba7e67e92e2135b Mon Sep 17 00:00:00 2001 From: Anthony PERARD Date: Mon, 1 Jul 2019 12:14:03 +0100 Subject: OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() Calling DisconnectController() on children isn't part of the job of EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate resources allocated in Start(). The disconnection will happen when both DevicePath and XenBus protocols gets uninstalled. Reported-by: Laszlo Ersek Signed-off-by: Anthony PERARD Message-Id: <20190701111403.7007-1-anthony.perard@citrix.com> Reviewed-by: Laszlo Ersek --- OvmfPkg/XenBusDxe/XenBusDxe.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'OvmfPkg') diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c index 7c07a96..634c7b7 100644 --- a/OvmfPkg/XenBusDxe/XenBusDxe.c +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c @@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop ( continue; } ChildData = XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo); - Status = gBS->DisconnectController (ChildData->Handle, NULL, NULL); - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n", - Status)); - continue; - } Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid, Dev->This->DriverBindingHandle, ChildData->Handle); -- cgit v1.1