From 060853f7aa578af06a86f20216b1df71a82531ab Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Wed, 4 Dec 2013 08:19:02 +0000 Subject: MdeModulePkg: SmmLockBox: remove wrong DepEx The SmmLockBox driver in "MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf" currently specifies a DepEx on EFI_SMM_SW_DISPATCH2_PROTOCOL. However, the driver doesn't use this protocol at all, either directly or indirectly. It calls SmiHandlerRegister() [MdeModulePkg/Core/PiSmmCore/Smi.c] to register SmmLockBoxHandler() (which serves LockBox requests). In turn, the SMM Core function SmiHandlerRegister() is also implemented without EFI_SMM_SW_DISPATCH2_PROTOCOL. The DepEx has been present since the initial commit of the SmmLockBox driver (SVN r12029); it is probably superfluous. Let's remove it. (Alternatively, we could extend OvmfPkg/EmuSmmDxe to fake this protocol, and return EFI_UNSUPPORTED when any member is called.) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jiewen Yao git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14930 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'MdeModulePkg/Universal/LockBox') diff --git a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf index 529ca77..1804e8a 100644 --- a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf +++ b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf @@ -60,5 +60,4 @@ gEfiLockBoxProtocolGuid ## PRODUCED [Depex] - gEfiSmmSwDispatch2ProtocolGuid - + TRUE -- cgit v1.1