From d691abec1bae4db5e4c58be7dbce40974d810f7a Mon Sep 17 00:00:00 2001 From: Michael Kinney Date: Thu, 18 Feb 2016 09:46:25 -0800 Subject: UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported() The function CheckFeatureSupported() is used as an EFI_AP_PROCEDURE in the MP Services Protocol service StartAllAPs(). Any function used as an EFI_AP_PROCEDURE must use EFIAPI calling convention. Cc: Laszlo Ersek Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney Reviewed-by: Jeff Fan Reviewed-by: Laszlo Ersek Reviewed-by: Jiewen Yao --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 11 +++++++---- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 7 +++++-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c index ec4ec9b..2078421 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c @@ -1,7 +1,7 @@ /** @file Enable SMM profile. -Copyright (c) 2012 - 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -928,10 +928,13 @@ InitSmmProfileInternal ( /** Check if XD feature is supported by a processor. + @param[in,out] Buffer The pointer to private data buffer. + **/ VOID +EFIAPI CheckFeatureSupported ( - VOID + IN OUT VOID *Buffer ) { UINT32 RegEax; @@ -1001,7 +1004,7 @@ CheckProcessorFeature ( // // Check if XD and BTS are supported on all processors. // - CheckFeatureSupported (); + CheckFeatureSupported (NULL); // //Check on other processors if BSP supports this @@ -1009,7 +1012,7 @@ CheckProcessorFeature ( if (mXdSupported || mBtsSupported) { MpServices->StartupAllAPs ( MpServices, - (EFI_AP_PROCEDURE) CheckFeatureSupported, + CheckFeatureSupported, TRUE, NULL, 0, diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h index 4548467..c6ce1f5 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h @@ -1,7 +1,7 @@ /** @file SMM profile header file. -Copyright (c) 2012 - 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -95,10 +95,13 @@ PageFaultIdtHandlerSmmProfile ( /** Check if XD feature is supported by a processor. + @param[in,out] Buffer The pointer to private data buffer. + **/ VOID +EFIAPI CheckFeatureSupported ( - VOID + IN OUT VOID *Buffer ); /** -- cgit v1.1