summaryrefslogtreecommitdiff
path: root/ArmVirtPkg/FdtClientDxe
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-03-09 16:59:34 +0100
committerArd Biesheuvel <ard.biesheuvel@linaro.org>2017-03-09 18:37:04 +0100
commit78c41ff519b187d8979cda7074f007a6323f9acd (patch)
treedd6d948f9073699de00da92e06839c1fdfde37f3 /ArmVirtPkg/FdtClientDxe
parent18f6d4df9ece8b91b86511bcdd1cf7da478c3627 (diff)
downloadedk2-78c41ff519b187d8979cda7074f007a6323f9acd.zip
edk2-78c41ff519b187d8979cda7074f007a6323f9acd.tar.gz
edk2-78c41ff519b187d8979cda7074f007a6323f9acd.tar.bz2
ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent
Instead of having a build time switch to prevent the FDT configuration table from being installed, make this behavior dependent on whether we are passing ACPI tables to the OS. This is done by looking for the ACPI 2.0 configuration table, and only installing the FDT one if the ACPI one cannot be found. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Diffstat (limited to 'ArmVirtPkg/FdtClientDxe')
-rw-r--r--ArmVirtPkg/FdtClientDxe/FdtClientDxe.c16
-rw-r--r--ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf5
2 files changed, 13 insertions, 8 deletions
diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
index 4cf79f7..21c1074 100644
--- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
+++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
@@ -17,9 +17,11 @@
#include <Library/DebugLib.h>
#include <Library/UefiDriverEntryPoint.h>
#include <Library/UefiBootServicesTableLib.h>
+#include <Library/UefiLib.h>
#include <Library/HobLib.h>
#include <libfdt.h>
+#include <Guid/Acpi.h>
#include <Guid/EventGroup.h>
#include <Guid/Fdt.h>
#include <Guid/FdtHob.h>
@@ -316,12 +318,16 @@ OnReadyToBoot (
)
{
EFI_STATUS Status;
+ VOID *Table;
- if (!FeaturePcdGet (PcdPureAcpiBoot)) {
- //
- // Only install the FDT as a configuration table if we want to leave it up
- // to the OS to decide whether it prefers ACPI over DT.
- //
+ //
+ // Only install the FDT as a configuration table if we are not exposing
+ // ACPI 2.0 (or later) tables. Note that the legacy ACPI table GUID has
+ // no meaning on ARM since we need at least ACPI 5.0 support, and the
+ // 64-bit ACPI 2.0 table GUID is mandatory in that case.
+ //
+ Status = EfiGetSystemConfigurationTable (&gEfiAcpi20TableGuid, &Table);
+ if (EFI_ERROR (Status) || Table == NULL) {
Status = gBS->InstallConfigurationTable (&gFdtTableGuid, mDeviceTreeBase);
ASSERT_EFI_ERROR (Status);
}
diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf
index 0001772..9861f41 100644
--- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf
+++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf
@@ -37,17 +37,16 @@
HobLib
UefiBootServicesTableLib
UefiDriverEntryPoint
+ UefiLib
[Protocols]
gFdtClientProtocolGuid ## PRODUCES
[Guids]
+ gEfiAcpi20TableGuid
gEfiEventReadyToBootGuid
gFdtHobGuid
gFdtTableGuid
-[FeaturePcd]
- gArmVirtTokenSpaceGuid.PcdPureAcpiBoot
-
[Depex]
TRUE