diff options
author | Qiu Shumin <shumin.qiu@intel.com> | 2015-08-14 07:20:09 +0000 |
---|---|---|
committer | shenshushi <shenshushi@Edk2> | 2015-08-14 07:20:09 +0000 |
commit | a0f2af3a74170cb8fa715711b791f0f606a25c2e (patch) | |
tree | f3d6bae330d459ad3e2265f84553441e81de6587 | |
parent | 6aeb75980f3e53389817cd729140187d5083d5b8 (diff) | |
download | edk2-a0f2af3a74170cb8fa715711b791f0f606a25c2e.zip edk2-a0f2af3a74170cb8fa715711b791f0f606a25c2e.tar.gz edk2-a0f2af3a74170cb8fa715711b791f0f606a25c2e.tar.bz2 |
ShellPkg\Tftp.c: Refine parameter name and use implicit comparison for BOOLEAN variable.
1. Refine parameter name to consistent with function headers.
2. To avoid potential bug BOOLEAN values should not use explicit comparisons to TRUE or FALSE.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18222 6f19259b-4bc3-4df7-8a09-765794883524
-rw-r--r-- | ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c index d837485..d2f7046 100644 --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c @@ -73,7 +73,7 @@ STATIC EFI_STATUS
GetNicName (
IN EFI_HANDLE ControllerHandle,
- IN UINTN Index,
+ IN UINTN NicNumber,
OUT CHAR16 *NicName
);
@@ -524,7 +524,7 @@ ShellCommandRunTftp ( );
}
- if ((UserNicName != NULL) && (NicFound == FALSE)) {
+ if ((UserNicName != NULL) && (!NicFound)) {
ShellPrintHiiEx (
-1, -1, NULL, STRING_TOKEN (STR_TFTP_ERR_NIC_NOT_FOUND),
gShellTftpHiiHandle, UserNicName
|