summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorklu2 <klu2@6f19259b-4bc3-4df7-8a09-765794883524>2006-05-08 03:34:21 +0000
committerklu2 <klu2@6f19259b-4bc3-4df7-8a09-765794883524>2006-05-08 03:34:21 +0000
commit19ce77c3e90fbc5a9029163ef2813592127c4498 (patch)
treeaedcd77bed7f8084bc211c1774122836288113c6
parent845fdeba640d599ee72d4a33bb2a5e49de0e52b1 (diff)
downloadedk2-19ce77c3e90fbc5a9029163ef2813592127c4498.zip
edk2-19ce77c3e90fbc5a9029163ef2813592127c4498.tar.gz
edk2-19ce77c3e90fbc5a9029163ef2813592127c4498.tar.bz2
It is legal that same base name exist in one FPD file. In future, we should use "Guid, Version, Package" and "Arch" to differ a module. So currently, warning should be disabled.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@108 6f19259b-4bc3-4df7-8a09-765794883524
-rw-r--r--Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java14
1 files changed, 6 insertions, 8 deletions
diff --git a/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java b/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java
index 9929005..71a30b6 100644
--- a/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java
+++ b/Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java
@@ -373,15 +373,13 @@ public class CollectPCDAction {
if(Token.PCD_USAGE.UNKNOWN != token.isUsageInstanceExist(moduleName)) {
//
- // BUGBUG: It should *not* throw exception here. Becaues in MdePkg.fpd,
- // more than on BaseLib exist. But why? need confirmation.
+ // BUGBUG: It is legal that same base name exist in one FPD file. In furture
+ // we should use "Guid, Version, Package" and "Arch" to differ a module.
+ // So currently, warning should be disabled.
//
- //throw new EntityException(
- // "In module " + moduleName + " exist more than one PCD token " + token.cName
- // );
- ActionMessage.warning(this,
- "In module " + moduleName + " exist more than one PCD token " + token.cName
- );
+ //ActionMessage.warning(this,
+ // "In module " + moduleName + " exist more than one PCD token " + token.cName
+ // );
return null;
}