summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Brasen <jbrasen@nvidia.com>2024-06-03 08:36:17 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2024-06-06 05:41:00 +0000
commit65b0d08786888284cd1bb705c58f53a65ae443b0 (patch)
tree7b95366c89d50f541469f6be5b37d26b6d3ca985
parentb45aff0dc9cb87f316eb17a11e5d4438175d9cca (diff)
downloadedk2-65b0d08786888284cd1bb705c58f53a65ae443b0.zip
edk2-65b0d08786888284cd1bb705c58f53a65ae443b0.tar.gz
edk2-65b0d08786888284cd1bb705c58f53a65ae443b0.tar.bz2
MdeModulePkg/HiiDatabaseDxe: Remove assert for VarStoreId = 0
It is legal for the VarStoreId of a question to be 0 per the UEFI spec: "Specifies the identifier of a previously declared variable store to use when storing the question’s value. A value of zero indicates no associated variable store." Instead of hitting an assert just skip this question as there is no value to return. Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
-rw-r--r--MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
index 6e79178..426dead 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
@@ -2101,8 +2101,9 @@ ExtractConfigRequest (
//
// Header->VarStoreId == 0 means no storage for this question.
//
- ASSERT (Header->VarStoreId != 0);
- DEBUG ((DEBUG_INFO, "Varstore Id: 0x%x\n", Header->VarStoreId));
+ if (Header->VarStoreId == 0) {
+ continue;
+ }
Storage = FindStorageFromVarId (FormPackage, Header->VarStoreId);
ASSERT (Storage != NULL);