From 4d7031437c7a81b52c776d4ae1e32741bdb851ca Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 31 Aug 2021 09:55:01 -0700 Subject: pylint: turn on superflous-parens We have a lot of these. Some of them are harmless, if unidiomatic, such as `if (condition)`, others are potentially dangerous `assert(...)`, as `assert(condtion)` works as expected, but `assert(condition, message)` will result in an assertion that never triggers, as what you're actually asserting is `bool(tuple[2])`, which will always be true. --- unittests/allplatformstests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'unittests/allplatformstests.py') diff --git a/unittests/allplatformstests.py b/unittests/allplatformstests.py index ee199f1..828ca58 100644 --- a/unittests/allplatformstests.py +++ b/unittests/allplatformstests.py @@ -2621,7 +2621,7 @@ class AllPlatformTests(BasePlatformTests): for i in targets: for out in i['filename']: - assert(os.path.relpath(out, self.builddir).startswith('meson-out')) + assert os.path.relpath(out, self.builddir).startswith('meson-out') def test_introspect_json_dump(self): testdir = os.path.join(self.unit_test_dir, '57 introspection') -- cgit v1.1