From c91a6ad0130e64fabf30b6bae58ae266453ab86a Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Tue, 7 Mar 2023 00:36:45 -0500 Subject: re-deduplicate feature warnings printed at the end of setup In commit eaf365cb3ef4f1c2ba66e07237d86a44089aff4f we explicitly sorted them for neatness, with the rationale that we were restoring intentional behavior and we only need a set for stylistic purposes. This actually wasn't true, because we never sorted them to begin with (we did sort the version numbers), but sorting them is fine. The bigger issue is that we actually used a set to avoid printing the same feature type multiple times. Now we do print them multiple times -- because each registered feature includes the unique node. Fix this by using both sorted and a set. Fix tests that should in retrospect have flagged this as an issue, but were added later on in the same series to check something else entirely, happen to cover this too, and were presumably copied directly from stdout as-is... --- test cases/common/40 options/test.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test cases/common') diff --git a/test cases/common/40 options/test.json b/test cases/common/40 options/test.json index 3b34c44..c7c7f00 100644 --- a/test cases/common/40 options/test.json +++ b/test cases/common/40 options/test.json @@ -1,7 +1,7 @@ { "stdout": [ { - "line": " * 1.1.0: {'\"boolean option\" keyword argument \"value\" of type str', '\"boolean option\" keyword argument \"value\" of type str', '\"integer option\" keyword argument \"value\" of type str'}" + "line": " * 1.1.0: {'\"boolean option\" keyword argument \"value\" of type str', '\"integer option\" keyword argument \"value\" of type str'}" } ] } -- cgit v1.1