From 69a5c950a3a70fe2e31a8a35f0be51ded89c4937 Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Wed, 7 Apr 2021 08:32:40 -0400 Subject: pkgconfig: Do not escape custom variables We need to escape space in variables that gets into cflags or libs because otherwise we cannot split compiler args when paths contains spaces. But custom variables are unlikely to be path that gets used in cflags/libs, and escaping them cause regression in GStreamer that use space as separator in a list variable. --- run_unittests.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'run_unittests.py') diff --git a/run_unittests.py b/run_unittests.py index fe664cb..f65eba3 100755 --- a/run_unittests.py +++ b/run_unittests.py @@ -6545,6 +6545,8 @@ class LinuxlikeTests(BasePlatformTests): self.assertEqual(libhello_nolib.get_compile_args(), []) self.assertEqual(libhello_nolib.get_pkgconfig_variable('foo', {}), 'bar') self.assertEqual(libhello_nolib.get_pkgconfig_variable('prefix', {}), self.prefix) + self.assertEqual(libhello_nolib.get_pkgconfig_variable('escaped_var', {}), 'hello\ world') + self.assertEqual(libhello_nolib.get_pkgconfig_variable('unescaped_var', {}), 'hello world') cc = env.detect_c_compiler(MachineChoice.HOST) if cc.get_id() in {'gcc', 'clang'}: -- cgit v1.1