From 8bc656cccb2df30ab463699ebb8ad0a5c759ad17 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 16 Nov 2020 12:41:02 +0100 Subject: =?UTF-8?q?Fix=20clang-tidy=20return=20value=20reporting=20(Part?= =?UTF-8?q?=20=E2=85=A1)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It turns out my first attempt to fix this in 00d5ef3191e5 ("Fix clang-tidy return value reporting (#7949)") is not sufficient: The local variable returncode is never updated and stays at 0. This fixes the returncode calculation. Fixes: cce172432be3 ("Use run-clang-tidy when available.") --- mesonbuild/scripts/clangtidy.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mesonbuild') diff --git a/mesonbuild/scripts/clangtidy.py b/mesonbuild/scripts/clangtidy.py index f920126..8d366c8 100644 --- a/mesonbuild/scripts/clangtidy.py +++ b/mesonbuild/scripts/clangtidy.py @@ -36,7 +36,7 @@ def manual_clangtidy(srcdir_name: str, builddir_name: str) -> int: if strf.startswith(builddir_name): continue futures.append(e.submit(subprocess.run, ['clang-tidy', '-p', builddir_name, strf])) - [max(returncode, x.result().returncode) for x in futures] + returncode = max([x.result().returncode for x in futures]) return returncode def clangtidy(srcdir_name: str, builddir_name: str) -> int: -- cgit v1.1