From 8efdcca93063fb224c53ae2d6f57b8dacf082456 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Sun, 14 Jan 2018 14:04:45 +0000 Subject: Make Dependency.get_methods() a static method Since this is only consulted while constructing the Dependency object, it's result doesn't depend on the instance (and it would make no sense if it did) --- mesonbuild/dependencies/ui.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'mesonbuild/dependencies/ui.py') diff --git a/mesonbuild/dependencies/ui.py b/mesonbuild/dependencies/ui.py index c066c31..00cd56d 100644 --- a/mesonbuild/dependencies/ui.py +++ b/mesonbuild/dependencies/ui.py @@ -67,7 +67,8 @@ class GLDependency(ExternalDependency): self.version = '1' return - def get_methods(self): + @staticmethod + def get_methods(): if mesonlib.is_osx() or mesonlib.is_windows(): return [DependencyMethods.PKGCONFIG, DependencyMethods.SYSTEM] else: @@ -337,7 +338,8 @@ class QtBaseDependency(ExternalDependency): else: return qvars['QT_INSTALL_BINS'] - def get_methods(self): + @staticmethod + def get_methods(): return [DependencyMethods.PKGCONFIG, DependencyMethods.QMAKE] def get_exe_args(self, compiler): @@ -420,7 +422,8 @@ class SDL2Dependency(ExternalDependency): return mlog.log('Dependency', mlog.bold('sdl2'), 'found:', mlog.red('NO')) - def get_methods(self): + @staticmethod + def get_methods(): if mesonlib.is_osx(): return [DependencyMethods.PKGCONFIG, DependencyMethods.CONFIG_TOOL, DependencyMethods.EXTRAFRAMEWORK] else: @@ -526,5 +529,6 @@ class VulkanDependency(ExternalDependency): self.link_args.append(lib) return - def get_methods(self): + @staticmethod + def get_methods(): return [DependencyMethods.PKGCONFIG, DependencyMethods.SYSTEM] -- cgit v1.1