From 7972c49bda5c2fcd6d647f45f5a5fa250f68f4b6 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Mon, 29 Aug 2022 19:25:36 -0400 Subject: dependencies: simplify log_tried into a staticmethod It doesn't really need class instantiation to just know what type it is, and this way we can get the information early if a dependency fails to init. --- mesonbuild/dependencies/base.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'mesonbuild/dependencies/base.py') diff --git a/mesonbuild/dependencies/base.py b/mesonbuild/dependencies/base.py index 550a88f..afe70c7 100644 --- a/mesonbuild/dependencies/base.py +++ b/mesonbuild/dependencies/base.py @@ -387,7 +387,8 @@ class ExternalDependency(Dependency, HasNativeKwarg): def log_info(self) -> str: return '' - def log_tried(self) -> str: + @staticmethod + def log_tried() -> str: return '' # Check if dependency version meets the requirements @@ -602,7 +603,8 @@ class SystemDependency(ExternalDependency): super().__init__(DependencyTypeName('system'), env, kwargs, language=language) self.name = name - def log_tried(self) -> str: + @staticmethod + def log_tried() -> str: return 'system' @@ -615,5 +617,6 @@ class BuiltinDependency(ExternalDependency): super().__init__(DependencyTypeName('builtin'), env, kwargs, language=language) self.name = name - def log_tried(self) -> str: + @staticmethod + def log_tried() -> str: return 'builtin' -- cgit v1.1