From 1f342a208122c86fa564688c518ecc63b67650df Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Mon, 18 Mar 2019 15:52:04 -0700 Subject: dependencies/openmp: Don't special case OpenMP Currently we specialcase OpenMP like we do threads, with a special `need_openmp` method. This seems like a great idea, but doesn't work out in practice, as well as it complicates the opemp implementation. If GCC is built without opemp support for example, we still add -fopenmp to the the command line, which results in compilation errors. This patch discards that and treats it like a normal dependency, removes the need_openmp() method, and sets the compile_args attributes from the compiler. Fixes #5115 --- mesonbuild/compilers/c.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'mesonbuild/compilers') diff --git a/mesonbuild/compilers/c.py b/mesonbuild/compilers/c.py index 3548b6d..2983ce7 100644 --- a/mesonbuild/compilers/c.py +++ b/mesonbuild/compilers/c.py @@ -410,8 +410,6 @@ class CCompiler(Compiler): args += d.get_compile_args() if d.need_threads(): args += self.thread_flags(env) - elif d.need_openmp(): - args += self.openmp_flags() if mode == 'link': # Add link flags needed to find dependencies args += d.get_link_args() -- cgit v1.1