From 188c552dcfe4aad30041263685eb421240a72e6f Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Fri, 2 Sep 2022 11:49:37 -0700 Subject: pylint: enable use-maxsplit-arg This finds a bunch of places where we can do more efficient string splitting. --- mesonbuild/compilers/detect.py | 4 ++-- mesonbuild/compilers/rust.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'mesonbuild/compilers') diff --git a/mesonbuild/compilers/detect.py b/mesonbuild/compilers/detect.py index 4414a57..5c63d2d 100644 --- a/mesonbuild/compilers/detect.py +++ b/mesonbuild/compilers/detect.py @@ -473,7 +473,7 @@ def _detect_c_or_cpp_compiler(env: 'Environment', lang: str, for_machine: Machin break else: raise EnvironmentException(f'Failed to detect MSVC compiler version: stderr was\n{err!r}') - cl_signature = lookat.split('\n')[0] + cl_signature = lookat.split('\n', maxsplit=1)[0] match = re.search(r'.*(x86|x64|ARM|ARM64)([^_A-Za-z0-9]|$)', cl_signature) if match: target = match.group(1) @@ -593,7 +593,7 @@ def detect_cuda_compiler(env: 'Environment', for_machine: MachineChoice) -> Comp # - CUDA Toolkit 8.0.61 requires NVIDIA Driver 375.26 # Luckily, the "V" also makes it very simple to extract # the full version: - version = out.strip().split('V')[-1] + version = out.strip().rsplit('V', maxsplit=1)[-1] cpp_compiler = detect_cpp_compiler(env, for_machine) cls = CudaCompiler env.coredata.add_lang_args(cls.language, cls, for_machine, env) diff --git a/mesonbuild/compilers/rust.py b/mesonbuild/compilers/rust.py index 296c539..a7bab0f 100644 --- a/mesonbuild/compilers/rust.py +++ b/mesonbuild/compilers/rust.py @@ -111,7 +111,7 @@ class RustCompiler(Compiler): def get_sysroot(self) -> str: cmd = self.exelist + ['--print', 'sysroot'] p, stdo, stde = Popen_safe(cmd) - return stdo.split('\n')[0] + return stdo.split('\n', maxsplit=1)[0] def get_debug_args(self, is_debug: bool) -> T.List[str]: return clike_debug_args[is_debug] -- cgit v1.1