From 4030e7cb7ad54dd2df0686f41459fc6293c8284f Mon Sep 17 00:00:00 2001 From: John Ericson Date: Sun, 12 May 2019 12:38:11 -0400 Subject: UserOption no longer has a name field. This avoids the duplication where the option is stored in a dict at its name, and also contains its own name. In general, the maxim in programming is things shouldn't know their own name, so removed the name field just leaving the option's position in the dictionary as its name. --- mesonbuild/backend/backends.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'mesonbuild/backend') diff --git a/mesonbuild/backend/backends.py b/mesonbuild/backend/backends.py index 0565de3..d74157f 100644 --- a/mesonbuild/backend/backends.py +++ b/mesonbuild/backend/backends.py @@ -103,8 +103,7 @@ class TestSerialisation: self.protocol = protocol class OptionProxy: - def __init__(self, name, value): - self.name = name + def __init__(self, value): self.value = value class OptionOverrideProxy: @@ -122,7 +121,7 @@ class OptionOverrideProxy: def _get_override(self, option_name, base_opt): if option_name in self.overrides: - return OptionProxy(base_opt.name, base_opt.validate_value(self.overrides[option_name])) + return OptionProxy(base_opt.validate_value(self.overrides[option_name])) return base_opt def get_backend_from_name(backend, build): -- cgit v1.1