From 5678468c2cc1f4639c68a95fb71f8212c846459b Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Mon, 22 Apr 2019 15:54:16 -0700 Subject: Don't use len() to test for container emptiness I ran the numbers once before (it's in the meson history) but it's *much* faster to *not* use len for testing if a container is empty or not. --- mesonbuild/backend/xcodebackend.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mesonbuild/backend/xcodebackend.py') diff --git a/mesonbuild/backend/xcodebackend.py b/mesonbuild/backend/xcodebackend.py index 990b824..7dd3674 100644 --- a/mesonbuild/backend/xcodebackend.py +++ b/mesonbuild/backend/xcodebackend.py @@ -748,7 +748,7 @@ class XCodeBackend(backends.Backend): gargs = self.build.global_args.get(lang, []) targs = target.get_extra_args(lang) args = pargs + gargs + targs - if len(args) > 0: + if args: langargs[langnamemap[lang]] = args symroot = os.path.join(self.environment.get_build_dir(), target.subdir) self.write_line('%s /* %s */ = {' % (valid, buildtype)) @@ -783,7 +783,7 @@ class XCodeBackend(backends.Backend): self.write_line('GCC_PREFIX_HEADER = "$(PROJECT_DIR)/%s";' % relative_pch_path) self.write_line('GCC_PREPROCESSOR_DEFINITIONS = "";') self.write_line('GCC_SYMBOLS_PRIVATE_EXTERN = NO;') - if len(headerdirs) > 0: + if headerdirs: quotedh = ','.join(['"\\"%s\\""' % i for i in headerdirs]) self.write_line('HEADER_SEARCH_PATHS=(%s);' % quotedh) self.write_line('INSTALL_PATH = "%s";' % install_path) -- cgit v1.1