From e611b6748b7c9a66f348380d9bc1c24268adbbc4 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Mon, 19 Dec 2016 18:22:20 +0100 Subject: tree-wide: remove unused variables ./mesonbuild/scripts/regen_checker.py:35:5: F841 local variable 'scriptdir' is assigned to but never used scriptdir = os.path.split(__file__)[0] ^ ./mesonbuild/scripts/yelphelper.py:84:13: F841 local variable 'symfile' is assigned to but never used symfile = os.path.join(install_dir, m) ^ ./mesonbuild/backend/backends.py:164:13: F841 local variable 'lang' is assigned to but never used lang = comp.get_language() ^ ./mesonbuild/backend/ninjabackend.py:1286:9: F841 local variable 'scriptdir' is assigned to but never used scriptdir = self.environment.get_script_dir() ^ ./mesonbuild/backend/vs2010backend.py:736:9: F841 local variable 'additional_options_set' is assigned to but never used additional_options_set = True ^ Signed-off-by: Igor Gnatenko --- mesonbuild/backend/ninjabackend.py | 1 - 1 file changed, 1 deletion(-) (limited to 'mesonbuild/backend/ninjabackend.py') diff --git a/mesonbuild/backend/ninjabackend.py b/mesonbuild/backend/ninjabackend.py index a20a35f..4a85327 100644 --- a/mesonbuild/backend/ninjabackend.py +++ b/mesonbuild/backend/ninjabackend.py @@ -1283,7 +1283,6 @@ int dummy; outfile.write(command) outfile.write(description) outfile.write('\n') - scriptdir = self.environment.get_script_dir() outfile.write('\n') symrule = 'rule SHSYM\n' symcmd = ' command = "%s" "%s" %s %s %s %s $CROSS\n' % (ninja_quote(sys.executable), -- cgit v1.1 From 139e020ede8a954a276e69d5c1921884ef9725ce Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Mon, 19 Dec 2016 21:48:35 +0100 Subject: tree-wide: use proper 'not in' notation Let's be more pythonic and 'not is' seems really weird. Signed-off-by: Igor Gnatenko --- mesonbuild/backend/ninjabackend.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'mesonbuild/backend/ninjabackend.py') diff --git a/mesonbuild/backend/ninjabackend.py b/mesonbuild/backend/ninjabackend.py index 4a85327..d8fb732 100644 --- a/mesonbuild/backend/ninjabackend.py +++ b/mesonbuild/backend/ninjabackend.py @@ -268,7 +268,7 @@ int dummy; return False suffix = os.path.splitext(source)[1][1:] for lang in self.langs_cant_unity: - if not lang in target.compilers: + if lang not in target.compilers: continue if suffix in target.compilers[lang].file_suffixes: return False @@ -433,7 +433,7 @@ int dummy; def process_target_dependencies(self, target, outfile): for t in target.get_dependencies(): tname = t.get_basename() + t.type_suffix() - if not tname in self.processed_targets: + if tname not in self.processed_targets: self.generate_target(t, outfile) def custom_target_generator_inputs(self, target, outfile): @@ -2076,7 +2076,7 @@ rule FORTRAN_DEP_HACK result = [] for ld in link_deps: prospective = self.get_target_dir(ld) - if not prospective in result: + if prospective not in result: result.append(prospective) return result -- cgit v1.1