From f2d4a32370bb94e0f63ddb5f9f38d93dcab8687b Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Thu, 28 Mar 2019 08:56:10 -0700 Subject: dependencies/base: Pass correct arguments to subdependencies Currently InternalDependency.get_partial_dependency shadows the the input variables names, and then passes those new copies to the final object returned. It also passes them to the arguments of of get_partial_dependency for each subdependency, which is wrong. The code is supposed to proxy the original argumetn values to that instead of the shadowing values. To avoid that this patch renames the new values. --- docs/markdown/Reference-manual.md | 3 +++ 1 file changed, 3 insertions(+) (limited to 'docs/markdown') diff --git a/docs/markdown/Reference-manual.md b/docs/markdown/Reference-manual.md index 7668fa0..490ccf0 100644 --- a/docs/markdown/Reference-manual.md +++ b/docs/markdown/Reference-manual.md @@ -2148,6 +2148,9 @@ an external dependency with the following methods: dep3 will add `['-Werror=foo', '-Werror=bar']` to the compiler args of any target it is added to, but libfoo will not be added to the link_args. + + *Note*: A bug present until 0.51.0 results in the above behavior + not working correctly. The following arguments will add the following attributes: -- cgit v1.1