From 1cc57c4f3aa375297ba4373a291ab70d1259980e Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Fri, 3 Apr 2015 13:05:35 +0300 Subject: Error out if required framework dep is not found. --- dependencies.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'dependencies.py') diff --git a/dependencies.py b/dependencies.py index c276458..71cb0a7 100644 --- a/dependencies.py +++ b/dependencies.py @@ -593,7 +593,6 @@ class GnuStepDependency(Dependency): try: gp = subprocess.Popen([confprog, '--help'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) - gp.communicate() except FileNotFoundError: self.args = None @@ -782,7 +781,10 @@ def find_external_dependency(name, kwargs): except Exception as e: pkg_exc = e if mesonlib.is_osx(): - return ExtraFrameworkDependency(name, required) + fwdep = ExtraFrameworkDependency(name, required) + if required and not fwdep.found(): + raise DependencyException('Dependency "%s" nod found' % name) + return fwdep if pkg_exc is not None: raise pkg_exc return pkgdep -- cgit v1.1