From cfa6ff52e910e8cea88e3c7b74342add2efea900 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 5 Oct 2021 09:20:32 -0700 Subject: modules/gnome: Fix case that could never be hit due to bad types It's impossible to get a Holder here, we'd get the unholdered build types. Mypy points this out for us. --- mesonbuild/modules/gnome.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mesonbuild/modules/gnome.py b/mesonbuild/modules/gnome.py index 5921475..5d8b7b4 100644 --- a/mesonbuild/modules/gnome.py +++ b/mesonbuild/modules/gnome.py @@ -222,9 +222,9 @@ class GnomeModule(ExtensionModule): ifile = os.path.join(ifile.subdir, ifile.fname) elif isinstance(ifile, str): ifile = os.path.join(state.subdir, ifile) - elif isinstance(ifile, (interpreter.CustomTargetHolder, - interpreter.CustomTargetIndexHolder, - interpreter.GeneratedObjectsHolder)): + elif isinstance(ifile, (build.CustomTarget, + build.CustomTargetIndex, + build.GeneratedList)): m = 'Resource xml files generated at build-time cannot be used ' \ 'with gnome.compile_resources() because we need to scan ' \ 'the xml for dependencies. Use configure_file() instead ' \ -- cgit v1.1