From 048d941e9543f97087b2fce1032570bc0816738f Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Sun, 10 Sep 2017 18:13:34 +0300 Subject: Create WiX source file with the XML module rather than string manipulation. --- msi/createmsi.py | 103 +++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 93 insertions(+), 10 deletions(-) diff --git a/msi/createmsi.py b/msi/createmsi.py index 7b7ba68..bb6492c 100644 --- a/msi/createmsi.py +++ b/msi/createmsi.py @@ -17,6 +17,7 @@ import sys, os, subprocess, shutil, uuid from glob import glob import platform +import xml.etree.ElementTree as ET sys.path.append(os.getcwd()) from mesonbuild import coredata @@ -78,11 +79,13 @@ class Node: class PackageGenerator: def __init__(self): + self.product_name = 'Meson Build System' + self.manufacturer = 'The Meson Development Team' self.version = coredata.version.replace('dev', '') self.guid = 'DF5B3ECA-4A31-43E3-8CE4-97FC8A97212E' self.update_guid = '141527EE-E28A-4D14-97A4-92E6075D28B2' - self.main_xml = 'Meson.wxs' - self.main_o = 'Meson.wixobj' + self.main_xml = 'meson.wxs' + self.main_o = 'meson.wixobj' self.bytesize = '32' if '32' in platform.architecture()[0] else '64' self.final_output = 'meson-%s-%s.msi' % (self.version, self.bytesize) self.staging_dir = 'dist' @@ -91,7 +94,7 @@ class PackageGenerator: self.progfile_dir = 'ProgramFiles64Folder' self.component_platform = 'Win64="yes"' else: - self.platform_sr = '' + self.platform_str = '' self.progfile_dir = 'ProgramFilesFolder' self.component_platform = '' @@ -116,6 +119,51 @@ class PackageGenerator: def generate_files(self): + self.root = ET.Element('Wix', {'xmlns': 'http://schemas.microsoft.com/wix/2006/wi'}) + product = ET.SubElement(self.root, 'Product', { + 'Name': self.product_name, + 'Manufacturer': 'The Meson Development Team', + 'Id': self.guid, + 'UpgradeCode': self.update_guid, + 'Language': '1033', + 'Codepage': '1252', + 'Version': self.version, + }) + + ET.SubElement(product, 'Package', { + 'Id': '*', + 'Keywords': 'Installer', + 'Description': 'Meson %s installer' % self.version, + 'Comments': 'Meson is a high performance build system', + 'Manufacturer': 'The Meson Development Team', + 'InstallerVersion': '100', + 'Languages': '1033', + 'Compressed': 'yes', + 'SummaryCodepage': '1252', + }) + ET.SubElement(product, 'Media', { + 'Id': '1', + 'Cabinet': 'meson.cab', + 'EmbedCab': 'yes', + }) + targetdir = ET.SubElement(product, 'Directory', { + 'Id': 'TARGETDIR', + 'Name': 'SourceDir', + }) + progfiledir = ET.SubElement(targetdir, 'Directory', { + 'Id' : self.progfile_dir, + }) + installdir = ET.SubElement(progfiledir, 'Directory', { + 'Id': 'INSTALLDIR', + 'Name': 'Meson'}) + + ET.SubElement(product, 'Property', { + 'Id': 'WIXUI_INSTALLDIR', + 'Value': 'INSTALLDIR', + }) + ET.SubElement(product, 'UIRef', { + 'Id': 'WixUI_InstallDir', + }) assert(os.path.isdir(self.staging_dir)) comp_ref_xml = '' nodes = {} @@ -126,29 +174,64 @@ class PackageGenerator: ofile.write(xml_templ % (self.guid, self.update_guid, self.version, self.version, self.platform_str, self.progfile_dir)) self.component_num = 0 - self.create_xml(nodes, ofile, self.staging_dir) + self.create_xml(nodes, ofile, self.staging_dir, installdir) + feature = ET.SubElement(product, 'Feature', { + 'Id': 'DefaultFeature', + 'Level': '1', + }) + for i in range(self.component_num): + ET.SubElement(feature, 'ComponentRef', { + 'Id': 'ApplicationFiles%d' % i, + }) comp_ref_xml += comp_ref_templ % ('ApplicationFiles%d' % i) ofile.write(xml_footer_templ % comp_ref_xml) - def create_xml(self, nodes, ofile, root): - cur_node = nodes[root] + ET.ElementTree(self.root).write(self.main_xml, encoding='utf-8',xml_declaration=True) + + def create_xml(self, nodes, ofile, current_dir, parent_xml_node): + cur_node = nodes[current_dir] if cur_node.files: + comp_xml_node = ET.SubElement(parent_xml_node, 'Component', { + 'Id': 'ApplicationFiles%d' % self.component_num, + 'Guid': gen_guid(), + }) + if self.bytesize == 64: + comp_xml_node.set('Win64', 'yes') + if self.component_num == 0: + ET.SubElement(comp_xml_node, 'Environment', { + 'Id': 'Environment', + 'Name': 'PATH', + 'Part': 'last', + 'System': 'yes', + 'Action': 'set', + 'Value': '[INSTALLDIR]', + }) ofile.write("\n" % (self.component_num, gen_guid(), self.component_platform)) if self.component_num == 0: ofile.write(path_addition_xml) self.component_num += 1 for f in cur_node.files: - file_source = os.path.join(root, f).replace('\\', '\\\\') - file_id = os.path.join(root, f).replace('\\', '_').replace('#', '_').replace('-', '_') + file_source = os.path.join(current_dir, f).replace('\\', '\\\\') + file_id = os.path.join(current_dir, f).replace('\\', '_').replace('#', '_').replace('-', '_') + ET.SubElement(comp_xml_node, 'File', { + 'Id': file_id, + 'Name': f, + 'Source': os.path.join(current_dir, f), + }) ofile.write(file_templ % (file_id, f, file_source)) ofile.write('\n') for dirname in cur_node.dirs: - dir_id = os.path.join(root, dirname).replace('\\', '_').replace('/', '_') + dir_id = os.path.join(current_dir, dirname).replace('\\', '_').replace('/', '_') + dir_node = ET.SubElement(parent_xml_node, 'Directory', { + 'Id': dir_id, + 'Name': dirname, + }) ofile.write('''\n''' % (dir_id, dirname)) - self.create_xml(nodes, ofile, os.path.join(root, dirname)) + self.create_xml(nodes, ofile, os.path.join(current_dir, dirname), dir_node) ofile.write('\n') + def build_package(self): -- cgit v1.1 From 41805f1b316403556ed5d427e0b723d4f44dc3e8 Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Sun, 10 Sep 2017 18:17:36 +0300 Subject: Delete XML string manipulation code. --- msi/createmsi.py | 90 ++++++++++---------------------------------------------- 1 file changed, 15 insertions(+), 75 deletions(-) mode change 100644 => 100755 msi/createmsi.py diff --git a/msi/createmsi.py b/msi/createmsi.py old mode 100644 new mode 100755 index bb6492c..1c91427 --- a/msi/createmsi.py +++ b/msi/createmsi.py @@ -22,50 +22,6 @@ import xml.etree.ElementTree as ET sys.path.append(os.getcwd()) from mesonbuild import coredata -xml_templ = ''' - - - - - - - - - -''' - -xml_footer_templ = ''' - - - - - -%s - - - - - - - -''' - -file_templ = ''' -''' - -comp_ref_templ = ''' -''' - -path_addition_xml = ''' -''' - - def gen_guid(): return str(uuid.uuid4()).upper() @@ -165,31 +121,24 @@ class PackageGenerator: 'Id': 'WixUI_InstallDir', }) assert(os.path.isdir(self.staging_dir)) - comp_ref_xml = '' nodes = {} - with open(self.main_xml, 'w') as ofile: - for root, dirs, files in os.walk(self.staging_dir): - cur_node = Node(dirs, files) - nodes[root] = cur_node - ofile.write(xml_templ % (self.guid, self.update_guid, self.version, self.version, - self.platform_str, self.progfile_dir)) - self.component_num = 0 - self.create_xml(nodes, ofile, self.staging_dir, installdir) - feature = ET.SubElement(product, 'Feature', { - 'Id': 'DefaultFeature', - 'Level': '1', + for root, dirs, files in os.walk(self.staging_dir): + cur_node = Node(dirs, files) + nodes[root] = cur_node + self.component_num = 0 + self.create_xml(nodes, self.staging_dir, installdir) + feature = ET.SubElement(product, 'Feature', { + 'Id': 'DefaultFeature', + 'Level': '1', + }) + + for i in range(self.component_num): + ET.SubElement(feature, 'ComponentRef', { + 'Id': 'ApplicationFiles%d' % i, }) - - for i in range(self.component_num): - ET.SubElement(feature, 'ComponentRef', { - 'Id': 'ApplicationFiles%d' % i, - }) - comp_ref_xml += comp_ref_templ % ('ApplicationFiles%d' % i) - ofile.write(xml_footer_templ % comp_ref_xml) - ET.ElementTree(self.root).write(self.main_xml, encoding='utf-8',xml_declaration=True) - def create_xml(self, nodes, ofile, current_dir, parent_xml_node): + def create_xml(self, nodes, current_dir, parent_xml_node): cur_node = nodes[current_dir] if cur_node.files: comp_xml_node = ET.SubElement(parent_xml_node, 'Component', { @@ -207,9 +156,6 @@ class PackageGenerator: 'Action': 'set', 'Value': '[INSTALLDIR]', }) - ofile.write("\n" % (self.component_num, gen_guid(), self.component_platform)) - if self.component_num == 0: - ofile.write(path_addition_xml) self.component_num += 1 for f in cur_node.files: file_source = os.path.join(current_dir, f).replace('\\', '\\\\') @@ -219,8 +165,6 @@ class PackageGenerator: 'Name': f, 'Source': os.path.join(current_dir, f), }) - ofile.write(file_templ % (file_id, f, file_source)) - ofile.write('\n') for dirname in cur_node.dirs: dir_id = os.path.join(current_dir, dirname).replace('\\', '_').replace('/', '_') @@ -228,11 +172,7 @@ class PackageGenerator: 'Id': dir_id, 'Name': dirname, }) - ofile.write('''\n''' % (dir_id, dirname)) - self.create_xml(nodes, ofile, os.path.join(current_dir, dirname), dir_node) - ofile.write('\n') - - + self.create_xml(nodes, os.path.join(current_dir, dirname), dir_node) def build_package(self): wixdir = 'c:\\Program Files\\Wix Toolset v3.11\\bin' -- cgit v1.1 From d3fab4c9655091b9635346f50dc19da01ecf44a6 Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Sun, 10 Sep 2017 20:04:47 +0300 Subject: Add installer option to not install Ninja. --- msi/createmsi.py | 91 ++++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 62 insertions(+), 29 deletions(-) diff --git a/msi/createmsi.py b/msi/createmsi.py index 1c91427..c635343 100755 --- a/msi/createmsi.py +++ b/msi/createmsi.py @@ -44,36 +44,53 @@ class PackageGenerator: self.main_o = 'meson.wixobj' self.bytesize = '32' if '32' in platform.architecture()[0] else '64' self.final_output = 'meson-%s-%s.msi' % (self.version, self.bytesize) - self.staging_dir = 'dist' + self.staging_dirs = ['dist', 'dist2'] if self.bytesize == '64': - self.platform_str = 'Platform="x64"' self.progfile_dir = 'ProgramFiles64Folder' - self.component_platform = 'Win64="yes"' else: - self.platform_str = '' self.progfile_dir = 'ProgramFilesFolder' - self.component_platform = '' + self.component_num = 0 + self.feature_properties = { + self.staging_dirs[0]: { + 'Id': 'MainProgram', + 'Title': 'Meson', + 'Description': 'Meson executables', + 'Level': '1', + 'Absent': 'disallow', + }, + self.staging_dirs[1]: { + 'Id': 'NinjaProgram', + 'Title': 'Ninja', + 'Description': 'Ninja build tool', + 'Level': '1', + } + } + self.feature_components = {} + for sd in self.staging_dirs: + self.feature_components[sd] = [] def build_dist(self): - if os.path.exists(self.staging_dir): - shutil.rmtree(self.staging_dir) + for sdir in self.staging_dirs: + if os.path.exists(sdir): + shutil.rmtree(sdir) + main_stage, ninja_stage = self.staging_dirs modules = [os.path.splitext(os.path.split(x)[1])[0] for x in glob(os.path.join('mesonbuild/modules/*'))] modules = ['mesonbuild.modules.' + x for x in modules if not x.startswith('_')] modulestr = ','.join(modules) subprocess.check_call(['c:\\Python\python.exe', 'c:\\Python\Scripts\\cxfreeze', '--target-dir', - self.staging_dir, + main_stage, '--include-modules', modulestr, 'meson.py']) - shutil.copy(shutil.which('ninja'), self.staging_dir) - if not os.path.exists(os.path.join(self.staging_dir, 'meson.exe')): + if not os.path.exists(os.path.join(main_stage, 'meson.exe')): sys.exit('Meson exe missing from staging dir.') - if not os.path.exists(os.path.join(self.staging_dir, 'ninja.exe')): + os.mkdir(ninja_stage) + shutil.copy(shutil.which('ninja'), ninja_stage) + if not os.path.exists(os.path.join(ninja_stage, 'ninja.exe')): sys.exit('Ninja exe missing from staging dir.') - def generate_files(self): self.root = ET.Element('Wix', {'xmlns': 'http://schemas.microsoft.com/wix/2006/wi'}) product = ET.SubElement(self.root, 'Product', { @@ -118,33 +135,49 @@ class PackageGenerator: 'Value': 'INSTALLDIR', }) ET.SubElement(product, 'UIRef', { - 'Id': 'WixUI_InstallDir', + 'Id': 'WixUI_FeatureTree', }) - assert(os.path.isdir(self.staging_dir)) - nodes = {} - for root, dirs, files in os.walk(self.staging_dir): - cur_node = Node(dirs, files) - nodes[root] = cur_node - self.component_num = 0 - self.create_xml(nodes, self.staging_dir, installdir) - feature = ET.SubElement(product, 'Feature', { - 'Id': 'DefaultFeature', + for sd in self.staging_dirs: + assert(os.path.isdir(sd)) + top_feature = ET.SubElement(product, 'Feature', { + 'Id': 'Complete', + 'Title': 'Meson ' + self.version, + 'Description': 'The complete package', + 'Display': 'expand', 'Level': '1', + 'ConfigurableDirectory': 'INSTALLDIR', }) - - for i in range(self.component_num): + for sd in self.staging_dirs: + nodes = {} + for root, dirs, files in os.walk(sd): + cur_node = Node(dirs, files) + nodes[root] = cur_node + self.create_xml(nodes, sd, installdir, sd) + self.build_features(nodes, top_feature, sd) + ET.ElementTree(self.root).write(self.main_xml, encoding='utf-8',xml_declaration=True) + # ElementTree can not do prettyprinting so do it manually + import xml.dom.minidom + doc = xml.dom.minidom.parse(self.main_xml) + with open(self.main_xml, 'w') as of: + of.write(doc.toprettyxml()) + + def build_features(self, nodes, top_feature, staging_dir): + feature = ET.SubElement(top_feature, 'Feature', self.feature_properties[staging_dir]) + for component_id in self.feature_components[staging_dir]: ET.SubElement(feature, 'ComponentRef', { - 'Id': 'ApplicationFiles%d' % i, + 'Id': component_id, }) - ET.ElementTree(self.root).write(self.main_xml, encoding='utf-8',xml_declaration=True) + - def create_xml(self, nodes, current_dir, parent_xml_node): + def create_xml(self, nodes, current_dir, parent_xml_node, staging_dir): cur_node = nodes[current_dir] if cur_node.files: + component_id = 'ApplicationFiles%d' % self.component_num comp_xml_node = ET.SubElement(parent_xml_node, 'Component', { - 'Id': 'ApplicationFiles%d' % self.component_num, + 'Id': component_id, 'Guid': gen_guid(), }) + self.feature_components[staging_dir].append(component_id) if self.bytesize == 64: comp_xml_node.set('Win64', 'yes') if self.component_num == 0: @@ -172,7 +205,7 @@ class PackageGenerator: 'Id': dir_id, 'Name': dirname, }) - self.create_xml(nodes, os.path.join(current_dir, dirname), dir_node) + self.create_xml(nodes, os.path.join(current_dir, dirname), dir_node, staging_dir) def build_package(self): wixdir = 'c:\\Program Files\\Wix Toolset v3.11\\bin' -- cgit v1.1 From a2ef1dc23b1d5e103aa4454fdd82a5773a6152ef Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Sun, 10 Sep 2017 20:37:22 +0300 Subject: Fix installer generation on 64 bit Windows. --- msi/createmsi.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/msi/createmsi.py b/msi/createmsi.py index c635343..3ad3af4 100755 --- a/msi/createmsi.py +++ b/msi/createmsi.py @@ -42,10 +42,10 @@ class PackageGenerator: self.update_guid = '141527EE-E28A-4D14-97A4-92E6075D28B2' self.main_xml = 'meson.wxs' self.main_o = 'meson.wixobj' - self.bytesize = '32' if '32' in platform.architecture()[0] else '64' - self.final_output = 'meson-%s-%s.msi' % (self.version, self.bytesize) + self.bytesize = 32 if '32' in platform.architecture()[0] else 64 + self.final_output = 'meson-%s-%d.msi' % (self.version, self.bytesize) self.staging_dirs = ['dist', 'dist2'] - if self.bytesize == '64': + if self.bytesize == 64: self.progfile_dir = 'ProgramFiles64Folder' else: self.progfile_dir = 'ProgramFilesFolder' @@ -103,17 +103,20 @@ class PackageGenerator: 'Version': self.version, }) - ET.SubElement(product, 'Package', { + package = ET.SubElement(product, 'Package', { 'Id': '*', 'Keywords': 'Installer', 'Description': 'Meson %s installer' % self.version, 'Comments': 'Meson is a high performance build system', 'Manufacturer': 'The Meson Development Team', - 'InstallerVersion': '100', + 'InstallerVersion': '200', 'Languages': '1033', 'Compressed': 'yes', 'SummaryCodepage': '1252', }) + + if self.bytesize == 64: + package.set('Platform', 'x64') ET.SubElement(product, 'Media', { 'Id': '1', 'Cabinet': 'meson.cab', -- cgit v1.1 From 68ac9b7a0b211745510ebb0edf6bdec7e3124832 Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Sun, 10 Sep 2017 21:42:45 +0300 Subject: Require installer version 5.0, which corresponds to Win 7 and up. --- msi/createmsi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msi/createmsi.py b/msi/createmsi.py index 3ad3af4..921e2ac 100755 --- a/msi/createmsi.py +++ b/msi/createmsi.py @@ -109,7 +109,7 @@ class PackageGenerator: 'Description': 'Meson %s installer' % self.version, 'Comments': 'Meson is a high performance build system', 'Manufacturer': 'The Meson Development Team', - 'InstallerVersion': '200', + 'InstallerVersion': '500', 'Languages': '1033', 'Compressed': 'yes', 'SummaryCodepage': '1252', -- cgit v1.1