aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-01-09ci: Fix pip installation in Cygwin on AzureNirbheek Chauhan1-1/+1
Python3 in Cygwin is now Python 3.8
2021-01-07mtest: print TAP subtest countPaolo Bonzini1-2/+15
The parentheses look ugly in the progress report. To keep it aligned with the test outcomes, remove them from the outcomes as well.
2021-01-07mtest: print time that the test has been runningPaolo Bonzini1-4/+18
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: align decimal point of test durationsPaolo Bonzini1-2/+9
2021-01-07mtest: create runners in advancePaolo Bonzini1-17/+24
Compute all options in advance so that we can compute the maximum timeout.
2021-01-07mtest: move timeout message to ConsoleLoggerPaolo Bonzini1-0/+4
This adds a point where to call the progress report flush() method. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: store timeout in TestRunPaolo Bonzini1-13/+13
This will be useful when printing the progress report. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: add more formatting options to TestHarness.formatPaolo Bonzini1-15/+34
Allow leaving extra space in the left column, as well as customizing parts of the printed line. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: align correctly tests with wide Unicode charactersPaolo Bonzini1-3/+13
This correctly formats tests with CJK names or, well, emoji. It is not perfect (for example it does not correctly format emoji that are variations of 1-wide characters), but it is as good as most terminal emulators. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: make test output parsing asynchronousPaolo Bonzini1-22/+34
Instead of slurping in the entire stream, build the TestResult along the way. This allows reporting the results of TAP and Rust subtests as they come in, either as part of the progress report or (in the future) as individual lines of the output.
2021-01-07mtest: move Rust parsing inside TestRunPaolo Bonzini1-41/+40
Make the code look like the TAP parser. This simplifies the introduction of asynchronous parsing.
2021-01-07mtest: read test stdout/stderr via asyncio pipesPaolo Bonzini1-21/+29
Instead of creating temporary files, get the StreamReaders from _run_subprocess's returned object. Through asyncio magic, their contents will be read as it becomes ready and then returned when the StreamReader.read future is awaited. Because of this change, the stdout and stderr can be easily preserved when TestSubprocess returns an additional_error. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: do not wait inside _run_subprocessPaolo Bonzini1-66/+81
We would like SingleTestRunner to run code before waiting on the process, for example starting tasks to read stdout and stderr. Return a new object that is able to complete _run_subprocess's task. In the next patch, SingleTestRunner will also use the object to get hold of the stdout and stderr StreamReaders. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: handle should_fail in common codePaolo Bonzini1-10/+4
This is common to all protocols, place the code in a single place.
2021-01-07mtest: reorder arguments to "complete"Paolo Bonzini1-6/+6
Put them in the same order as complete_*.
2021-01-07mtest: improve JUnit XML generation for TAP testsuitesPaolo Bonzini1-46/+52
Include the names from the TAP output and the SKIP/TODO explanations if present. Omit the classname attribute, it is optional. In order to enable this, TestRun.results becomes a list of TAPParser.Test objects. If in the future there are other kinds of subtest results a new class can be introduced, but for now it is enough. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: improvements to JUnit XML generationPaolo Bonzini1-6/+8
Omit the classname attribute, as it is optional, and add the duration. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest: extract TAP parsing out of TestRun.make_tapPaolo Bonzini1-44/+53
For now this is just a refactoring that simplifies the next patch. However, it will also come in handy when we will make the parsing asynchronous, because it will make it possible to access subtest results while the test runs. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-07mtest/TAPParser: use typing.NamedTuplePaolo Bonzini2-35/+50
It is cleaner than collections.namedtuple. It also catches that "count()" is a method on tuple, so rename the field to num_tests. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-06mtest: remove argument to the TAPParser constructorPaolo Bonzini2-8/+5
Pass the StringIO object to the parse method instead, because there will be no T.Iterator[str] to use in the asynchronous case. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-06mtest: allow parsing TAP line by linePaolo Bonzini1-63/+68
This is the first step towards asynchronous parsing of the TAP output. We will need to call the same code from both a "for" loop (for unit tests) and an "async for" loop (for mtest itself). Because the same function cannot be both a generator and an asynchronous generator, we need to build both on a common core. This commit therefore introduces a parse_line function that "parse" can call in a loop. All the local variables of TAPParser.parse move into "self". Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-06Merge pull request #7860 from dcbaker/wip/2020-10/rust-moduleJussi Pakkanen16-51/+364
Add a rust module
2021-01-05update codeowners with the rust moduleDylan Baker1-0/+1
2021-01-05modules: Add an unstable-rust moduleDylan Baker9-27/+229
Like other language specific modules this module is module for holding rust specific helpers. This commit adds a test() function, which simplifies using rust's internal unittest mechanism. Rust tests are generally placed in the same code files as they are testing, in contrast to languages like C/C++ and python which generally place the tests in separate translation units. For meson this is somewhat problematic from a repetition point of view, as the only changes are generally adding --test, and possibly some dependencies. The rustmod.test() method provides a mechanism to remove the repatition: it takes a rust target, copies it, and then addes the `--test` option, then creates a Test() target with the `rust` protocol. You can pass additional dependencies via the `dependencies` keyword. This all makes for a nice, DRY, test definition.
2021-01-05Fix last mention of Python 3.5. [skip ci]Jussi Pakkanen1-49/+56
2021-01-05interpreter: split code that creates a Test instanceDylan Baker1-5/+8
For modules to make use of, as they're not allowed to modify the Build instance directly.
2021-01-05interpreter: allow modules to create testsDylan Baker1-0/+2
2021-01-05mtest: Add support for rust unit testsDylan Baker7-2/+107
Rust has it's own built in unit test format, which is invoked by compiling a rust executable with the `--test` flag to rustc. The tests are then run by simply invoking that binary. They output a custom test format, which this patch adds parsing support for. This means that we can report each subtest in the junit we generate correctly, which should be helpful for orchestration systems like gitlab and jenkins which can parse junit XML.
2021-01-05mtest: Handle subtest results as a dictDylan Baker1-17/+17
for non tap tests we want to associate names with the tests, to that end store them as a dict. For TAP tests, we'll store the "name" as an integer string that coresponds to the order that the tests were run in.
2021-01-04fix: llvm toolset is "ClangCL" in VS2019.Luke Elliott1-1/+1
2021-01-04unit:cpp17: make C++17 test stricter checkMichael Hirsch1-5/+27
many compilers allowed "nodiscard" C++17 feature with pre-c++17 flags. The C++17 filesystem typically actually does require -std=c++17. This makes this unit test more representative of C++17 flag support.
2021-01-04Merge pull request #8080 from dcbaker/submit/option-key-typeJussi Pakkanen54-1082/+1341
Use an object for option keys
2021-01-04mintro: fix mypy warningDylan Baker1-4/+4
The output of list_targets is a pretty horrific jumble of things. We really need a TypeDict to make this not so terrible we can't deal with it, so for now just use Any.
2021-01-04fix LGTM warningsDylan Baker5-9/+8
2021-01-04Use a single coredata dictionary for optionsDylan Baker33-357/+322
This patches takes the options work to it's logical conclusion: A single flat dictionary of OptionKey: UserOptions. This allows us to simplify a large number of cases, as we don't need to check if an option is in this dict or that one (or any of 5 or 6, actually).
2021-01-04use OptionKey for builtin and base optionsDylan Baker32-431/+444
I would have prefered to do these seperatately, but they are combined in some cases, so it was much easier to convert them together. this eliminates the builtins_per_machine dict, as it's duplicated with the OptionKey's machine parameter.
2021-01-04move OptionKey to mesonlibDylan Baker19-238/+240
There's starting to be a lot of things including coredata that coredata needs to itself include. putting it in mesonlib makes more sense
2021-01-04use OptionKey for compiler_optionsDylan Baker26-317/+382
2021-01-04cmake: fix missing languages from CMake (fixes #8132)Daniel Mensinger9-8/+80
2021-01-04Add choices to OptionProxyDylan Baker4-25/+26
they're probably not strictly needed, but it makes mypy happy.
2021-01-04use new optionkey.is_* methodsDylan Baker3-3/+3
2021-01-04coredata: Add a type to the OptionKeyDylan Baker1-18/+43
This is useful for figuring out what kind of option this is. My hope is that in the longterm this is less useful, but we'll still want it for the configuration summary printing.
2021-01-04use OptionKey for backend_optionsDylan Baker6-21/+20
2021-01-04use OptionKey for coredata.user_optionsDylan Baker7-22/+39
2021-01-04movve insert_build_prefix to mconfDylan Baker2-9/+8
that's the only place it's used anyway.
2021-01-04use the OptionKey type for command line and machine filesDylan Baker6-124/+111
2021-01-04coredata: Add OptionKey typeDylan Baker1-0/+169
This is a complex key that can store multiple bits of data in a single place. It can be generated from a command line formatted string, and it's str method returns it to that form. It's intentionally immutable, use the evolve() method to create variations of an existing key.
2021-01-04run_unittests: Add fatal-warnings to test_command_lineDylan Baker1-8/+9
Otherwise bugs like "option c_args is unknown" can slip through. that's bad.
2021-01-04run_unittests: make another test inprocess safeDylan Baker1-2/+6
2021-01-04run_unittests: Make test_command_line safe witn inprocessDylan Baker1-14/+27
This is pretty important to be able to debug the test, as it's huge and really should be a test split into subtests.