aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-09-18pylint: Turn on a few more good warningsDylan Baker1-0/+4
2020-09-18pylint: Catch cases of `if len(container)` which should be replaced by `if ↵Dylan Baker3-3/+5
container` Unfortunately this doesn't catch other abuses of len(continauer) like, `len(container) <comparator> 0`, see: https://github.com/PyCQA/pylint/issues/3751
2020-09-18Some fixes for CompCertSebastian Meyer2-4/+4
1. Like with gcc's `ld`, also use the `group_start` code to create a `--start-group`/`--end-group` 2. xc16 tricked into believing the 'link_whole' was about `--*-group`, but it should use gcc's `--whole-archive` instead. 3. Not clear what the get_lib_prefix should really do, but for picolibc it seems I want just `''`. The problem with picolibc was that the `-l` would be prefixed to a lib like `picolib/libm/libm.a`. Though of course the `-l` would be necessary for just a plain `m` (that's what I assumed this would be used for). I think this might need some clarification from the meson devs ;-)
2020-09-18Support identifying msvc dependency prefix with a path starting with a backslashMartin Storsjö1-2/+7
2020-09-18msubprojects: Fix unit tests on WindowsXavier Claessens2-5/+6
2020-09-18msubprojects: Revert back to rev-parse instead of --show-currentXavier Claessens2-13/+26
It is undocumented in manpage, but --show-current is new in git 2.22 which is too recent for distros we want to support like Ubuntu 18.04.
2020-09-18msubprojects: Stop trying to guess subproject typeXavier Claessens3-18/+8
It was done to include them in `meson subprojects foreach` without --types argument, but it's better to special case missing --types and include wraps that have type=None too. It was a bad idea because that was messing them in `meson subprojects update`, now they are ignored by that command.
2020-09-18msubprojects: Add basic unit testsXavier Claessens1-2/+165
2020-09-18msubprojects: Avoid useless "no local changes to save" messageXavier Claessens1-3/+7
2020-09-18msubprojects: Fix checkout of new tag/branchXavier Claessens1-4/+9
If revision is a tag that does not exist locally, `git fetch origin <revision>` won't create it and checkout will fail. Using --refmap ensures that references exists locally.
2020-09-18msubprojects: Fix --types default valueXavier Claessens1-3/+5
2020-09-17backends: Treat build target as generator only when it's the first argNirbheek Chauhan3-5/+7
Otherwise it might be an argument to a script that just inspects the binary itself.
2020-09-17project tests: Verify that UWP cross binaries use the right archNirbheek Chauhan2-0/+38
This is a test for https://github.com/mesonbuild/meson/pull/7021, to verify that `link.exe` uses the correct architecture when targeting ARM64. Can be extended to other cross targets later.
2020-09-17project tests: Also check whether introspect worksNirbheek Chauhan1-0/+5
2020-09-17Rename [properties] to [built-in options]Nirbheek Chauhan1-1/+1
This is the new syntax. Avoids loud deprecation warnings.
2020-09-17project tests: Rename a variable for clarityNirbheek Chauhan1-5/+5
2020-09-17Revert "windows: reduce chance of going over path limit in backend/vs"Nirbheek Chauhan1-5/+4
This reverts commit 807f88739ebfa002c9a0b9acd3e24c9610fb02a2.
2020-09-17unittests: mock os.environ before mucking with itDylan Baker1-1/+4
2020-09-17tests: Make monkey patching smarterDylan Baker2-40/+15
There are two problems here. The first is that we're doing manual monkey patching which is fragile and verbose, when unittest.mock is designed specifically to solve this exact problem. The second is that we're monkey patching os.environ at two different levels with the same information. So let's only do it once.
2020-09-17windows: reduce chance of going over path limit in backend/vsPeter Harris1-4/+5
When building with vs2019 (not ninja), a path length error will be thrown if the path to a resource file is even remotely deep within the tree. This is largely because the target name includes the string "Windows resource for file 'full path'", which is then expanded twice (once for the .vcxproj itself, and once for IntDir) and added to the full path. When combined with the tiny path limits on Windows, it is easy to exceed path limits. This error is largely avoided by the ninja back-end. Unlike the vs back-end, the ninja back-end does not use target.get_id() as part of the project file path, nor does it use target.get_id() as part of get_target_private_dir(). Example error: error MSB4184: The expression "[MSBuild]::NormalizePath( C:\src\mesonbuild\Misc\FreeRDP-master\client\X11\xfreerdp\xfreerdp, f3f7317@@Windows resource for file 'Misc_FreeRDP-master_client_X11_xfreerdp_xfreerdp_xfreerdp.rc'@cus\, f3f7317@@Windows resource for file 'Misc_FreeRDP-master_client_X11_xfreerdp_xfreerdp_xfreerdp.rc'@cus. vcxproj.CopyComplete)" cannot be evaluated. Path: C:\src\mesonbuild\Misc\FreeRDP-master\client\X11\xfreerdp\xfreerdp\f3f7317 @@Windows resource for file 'Misc_FreeRDP-master_client_X11_xfreerdp_xfreerdp_xfreerdp.rc'@cus\f3f7317 @@Windows resource for file 'Misc_FreeRDP-master_client_X11_xfreerdp_xfreerdp_xfreerdp.rc'@cus. vcxproj.CopyComplete exceeds the OS max path limit. The fully qualified file name must be less than 260 characters.
2020-09-17Canonicalize target architectures aarch64/armv* into arm64/arm for MSVC toolsMartin Storsjö1-0/+4
If the architectures are taken from the output of "clang-cl --version", we need to convert these names into names that the MSVC tools accept as the -machine: parameter.
2020-09-17Fixed MacOS dylib custom targets not marked as linkableMarco Mastropaolo1-1/+1
2020-09-16linkers: fully type annotate and fix mypy issuesDylan Baker3-8/+27
This makes GnuDynamicLinker not suitable for instantiation, so the tests need to be changed to use the BFD class.
2020-09-16linkers/compilers: Move an emscripten method to the compilerDylan Baker2-7/+7
This needed an attribute the linker doesn't have.
2020-09-16linkers: Make id a class variable for DynamicLinkersDylan Baker1-33/+48
Originally I had this idea that you'd be able to pass the id in to be able to deduplicate some cases (like ld.gold and ld.bfd). That went away because it ended up being really un-dry, but this id per instance remained. Getting rid of it allows us to get rid of a bunch of otherwise useless super calls, which makes adding type annotations easier.
2020-09-16linkers: Fix argument errorDylan Baker1-1/+1
The name of the argument passed was not the name of the argument used.
2020-09-16envconfig: fix return type of get_env_var_pairDylan Baker1-4/+2
It doesn't return (None, None), it returns just None.
2020-09-15Add support for the CompCert C CompilerSebastian Meyer8-1/+247
* Add preliminary support for the CompCert C Compiler The intention is to use this with the picolibc, so some GCC flags are automatically filtered. Since CompCert uses GCC is for linking, those GCC-linker flags which are used by picolibc, are automatically prefixed with '-WUl', so that they're passed to GCC. Squashed commit of the following: commit 4e0ad66dca9de301d2e41e74aea4142afbd1da7d Author: Sebastian Meyer <meyer@absint.com> Date: Mon Aug 31 14:20:39 2020 +0200 remove '-fall' from default arguments, also filter -ftls-model=.* commit 41afa3ccc62ae72824eb319cb8b34b7e6693cb67 Author: Sebastian Meyer <meyer@absint.com> Date: Mon Aug 31 14:13:55 2020 +0200 use regex for filtering ccomp args commit d68d242d0ad22f8bf53923ce849da9b86b696a75 Author: Sebastian Meyer <meyer@absint.com> Date: Mon Aug 31 13:54:36 2020 +0200 filter some gcc arguments commit 982a01756266bddbbd211c54e8dbfa2f43dec38f Author: Sebastian Meyer <meyer@absint.com> Date: Fri Aug 28 15:03:14 2020 +0200 fix ccomp meson configuration commit dce0bea00b1caa094b1ed0c6c77cf6c12f0f58d9 Author: Sebastian Meyer <meyer@absint.com> Date: Thu Aug 27 13:02:19 2020 +0200 add CompCert to meson (does not fully work, yet) * remove unused import and s/cls/self/ fixes the two obvious LGTM warnings * CompCert: Do not ignore unsupported GCC flags Some are safe to ignore, however, as per https://github.com/mesonbuild/meson/pull/7674, they should not be ignored by meson itself. Instead the meson.build should take care to select only those which are actually supported by the compiler. * remove unused variable * Only add arguments once. * Apply suggestions from code review Co-authored-by: Dylan Baker <dylan@pnwbakers.com> * Remove erroneous ' ' from '-o {}'.format() As noticed by @dcbaker * added release note snippet for compcert * properly split parameters As suggested by @dcbaker, these parameters should be properly split into multiple strings. Co-authored-by: Dylan Baker <dylan@pnwbakers.com> * Update add_compcert_compiler.md Added a sentence about the state of the implementation (experimental); use proper markdown * properly separate arguments Co-authored-by: Dylan Baker <dylan@pnwbakers.com>
2020-09-14InternalDependency: Add as_link_whole() methodXavier Claessens8-0/+67
2020-09-15CI: don't update MSYS2 [skip ci]Christoph Reiter1-11/+0
This should use the package database from the installer, from the release choco provides and result in fewer potential changes overall.
2020-09-15CODEOWNERS: add dcbaker for compilers and linkers [skip ci]Dylan Baker1-0/+2
I probably know more about that code than anyone else, so I'm probably the right person to be reviewing stuff in there.
2020-09-13externalproject: Fix typing annotationXavier Claessens1-3/+3
2020-09-13external-project: Add typing annotationXavier Claessens2-11/+25
2020-09-13external-project: New module to build configure/make projectsXavier Claessens20-19/+654
This adds an experimental meson module to build projects with other build systems. Closes: #4316
2020-09-13Allow installing dir from build dirXavier Claessens2-2/+8
2020-09-13mcompile: Add some basic XCode supportNirbheek Chauhan2-1/+49
I wrote this to convert run_tests.get_backend_commands() over to the new meson wrappers, but that turned out to be harder than I expected, so just splitting this out for now.
2020-09-13Improve regexp for MSVC target arch detection againTamás Bálint Misius1-1/+1
2020-09-13Remove redudant checks in vs2010 backendVili Väinölä1-6/+3
- Implicit include dirs was checked twice in a row - Add define only if it does not yet exist rather than remove.
2020-09-13Add VS include directories to projects as wellVili Väinölä1-2/+3
- "Go To Document" action previously only worked on c/cpp files which had the include directories set but it was not possible to move from header to another header.
2020-09-11unit tests: Print total time taken for running testsNirbheek Chauhan1-2/+6
2020-09-11unit tests: Don't use pytest when running single testsNirbheek Chauhan1-10/+31
On my machine this spawns 24 processes and then runs like the single test I asked it to run. With this change, running a single test goes from 7 seconds to less than a second.
2020-09-11Add build machine compilers to project tests compiler reportJon Turney2-6/+31
When cross-compiling, also report build machine compilers in the compiler report produced by run_project_tests.py
2020-09-11Add a test run of MSVC ARM64 cross on Windows x64Jon Turney5-5/+52
Add a cross-file for MSVC UWP ARM64. Bump cidata tag to get an updated install.ps1 script (run by run.ps1) which sets the vcvars environment correctly when cross-compiling. Since arranging the correct environment for simultaneous cross and native 'cl' use is hard, this is test run uses '--cross-only' so we don't require a native compiler. Extend '--cross-only' so it also explicitly uses a machine file which makes all build machine compilers unusable.
2020-09-11Fix test 'common/122 llvm ir and assembly' for Windows ARMJon Turney3-10/+59
2020-09-11Skip test 'common/121 shared modules' on Windows UWPJon Turney1-1/+19
2020-09-11Store first line of VisualStudio compiler output as full_versionJon Turney1-1/+1
Store the first line of VisualStudio compiler output as full_version, so it gets output when we report compiler details.
2020-09-11Revert "Do not automatically set warning flags if buildtype is 'plain'"Eli Schwartz1-1/+1
This reverts commit 8ee1c9a07a3a35e3ed262fbc358fd86c257a966e. No rationale was given for this change prior to merging. After the fact it was described as desired by distro packagers, however as a distro packager I believe this commit hurts me. From a distro packaging perspective, we primarily care about one thing: previously building code should still build. Hence, -Werror is bad for our use case. meson handles this via -D werror which is different from -D warning_level and as long as the former is disabled, warnings in the build do not cause harm (but may attract review attention for upstream to fix). buildtype is a completely unrelated concern, and the intention for =plain is to disable debug or optimization settings that result in codegen differences and thus different built artifacts. This must not happen in distro builds because the *distributed programs* should conform to policy settings. Unfortunately, completely disabling warnings happens silently, and cannot be overridden even if you really, really believe you know what you're doing. It is thematically broken, since use of add_project_arguments() to add more -W flags is not likewise ignored. But if you try to add -Wall in that manner, meson will lecture you to use warning_level which you cannot do. And if you have custom warning flags which depend on options enabled by judicious use of -Wall via default_options: 'warning_level=1', then you end up with generated warnings complaining about your command line rather than your code, such as: cc1: warning: ‘-Wformat-y2k’ ignored without ‘-Wformat’ [-Wformat-y2k] cc1: warning: ‘-Wformat-extra-args’ ignored without ‘-Wformat’ [-Wformat-extra-args] cc1: warning: ‘-Wformat-zero-length’ ignored without ‘-Wformat’ [-Wformat-zero-length] cc1: warning: ‘-Wformat-contains-nul’ ignored without ‘-Wformat’ [-Wformat-contains-nul] cc1: warning: ‘-Wformat-security’ ignored without ‘-Wformat’ [-Wformat-security] which then break the build with -Werror. Throughout all this, a buildtype of "plain" does *not* disable -D werror=true, which is the part where distro builds actually break down! Users who both wish to disable debug/optimization codegen, *and* disable warning commentary, are encouraged to do so by doing both, not by doing one and having the other be assumed. Fixes #7399
2020-09-10msubprojects: Allow comma separated list of typesXavier Claessens4-11/+20
2020-09-10msubprojects: Fix review commentsXavier Claessens2-4/+10
2020-09-10git: Use Popen_safe to avoid encoding issuesXavier Claessens2-44/+48
generated by cgit v1.1 at 2025-08-03 20:13:51 +0000