diff options
author | Jussi Pakkanen <jpakkane@gmail.com> | 2021-04-29 19:18:41 +0300 |
---|---|---|
committer | Jussi Pakkanen <jpakkane@gmail.com> | 2021-05-01 23:34:14 +0300 |
commit | b2687e86c87a1dd2e254aeaf3355b3e98b82b730 (patch) | |
tree | f3b315d1f6e4f5b22b1e27158f4d019ce43092c2 /run_unittests.py | |
parent | 53f6ef3b7be92f17f9084f87c1eee5b521f8bb47 (diff) | |
download | meson-b2687e86c87a1dd2e254aeaf3355b3e98b82b730.zip meson-b2687e86c87a1dd2e254aeaf3355b3e98b82b730.tar.gz meson-b2687e86c87a1dd2e254aeaf3355b3e98b82b730.tar.bz2 |
Do not accidentally format files when only checking if they are formatted.
Diffstat (limited to 'run_unittests.py')
-rwxr-xr-x | run_unittests.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/run_unittests.py b/run_unittests.py index c52d13c..828c80e 100755 --- a/run_unittests.py +++ b/run_unittests.py @@ -5634,7 +5634,7 @@ class AllPlatformTests(BasePlatformTests): self._run(cmd + python_command + [script]) self.assertEqual('This is text.', self._run(cmd + [app]).strip()) - def test_clang_format(self): + def test_clang_format_check(self): if self.backend is not Backend.ninja: raise unittest.SkipTest(f'Skipping clang-format tests with {self.backend.name} backend') if not shutil.which('clang-format'): @@ -5658,9 +5658,10 @@ class AllPlatformTests(BasePlatformTests): output = self.build('clang-format-check') self.assertEqual(1, output.count('File reformatted:')) - # All code has been reformatted already, so it should be no-op now. + # The check format should not touch any files. Thus + # running format again has some work to do. output = self.build('clang-format') - self.assertEqual(0, output.count('File reformatted:')) + self.assertEqual(1, output.count('File reformatted:')) self.build('clang-format-check') def test_custom_target_implicit_include(self): |